Merge branch 'main' into extractMethodCleanup

Author: CyrusNajmabadi

eng/config/PublishData.json

@@ -215,6 +215,15 @@
       "vsMajorVersion": 17,
       "insertionTitlePrefix": "[d17.12]"
     },
+    "release/dev17.12-telmet": {
+      "nugetKind": [
+        "Shipping",
+        "NonShipping"
+      ],
+      "vsBranch": "rel/d17.12telmet",
+      "vsMajorVersion": 17,
+      "insertionTitlePrefix": "[d17.12]"
+    },
     "release/dev17.13": {
       "nugetKind": [
         "Shipping",

src/Analyzers/CSharp/Analyzers/RemoveUnreachableCode/RemoveUnreachableCodeHelpers.cs

@@ -18,11 +18,11 @@ public static ImmutableArray<ImmutableArray<StatementSyntax>> GetSubsequentUnrea
         switch (firstUnreachableStatement.Parent)
         {
             case BlockSyntax block:
-                siblingStatements = ImmutableArray.CreateRange(block.Statements);
+                siblingStatements = [.. block.Statements];
                 break;
 
             case SwitchSectionSyntax switchSection:
-                siblingStatements = ImmutableArray.CreateRange(switchSection.Statements);
+                siblingStatements = [.. switchSection.Statements];
                 break;
 
             case GlobalStatementSyntax globalStatement:

src/Analyzers/CSharp/CodeFixes/DocumentationComments/CSharpAddDocCommentNodesCodeFixProvider.cs

@@ -32,7 +32,7 @@ internal sealed class CSharpAddDocCommentNodesCodeFixProvider()
     protected override string NodeName { get; } = "param";
 
     protected override List<XmlNameAttributeSyntax> GetNameAttributes(XmlElementSyntax node)
-        => node.StartTag.Attributes.OfType<XmlNameAttributeSyntax>().ToList();
+        => [.. node.StartTag.Attributes.OfType<XmlNameAttributeSyntax>()];
 
     protected override string GetValueFromNameAttribute(XmlNameAttributeSyntax attribute)
         => attribute.Identifier.Identifier.ValueText;

src/Analyzers/CSharp/CodeFixes/GenerateParameterizedMember/CSharpGenerateParameterizedMemberService.cs

@@ -126,16 +126,16 @@ private ITypeParameterSymbol GetMethodTypeParameter(TypeSyntax type, Cancellatio
         }
 
         protected override ImmutableArray<RefKind> DetermineParameterModifiers(CancellationToken cancellationToken)
-            => _invocationExpression.ArgumentList.Arguments.Select(a => a.GetRefKind()).ToImmutableArray();
+            => [.. _invocationExpression.ArgumentList.Arguments.Select(a => a.GetRefKind())];
 
         protected override ImmutableArray<ITypeSymbol> DetermineParameterTypes(CancellationToken cancellationToken)
-            => _invocationExpression.ArgumentList.Arguments.Select(a => DetermineParameterType(a, cancellationToken)).ToImmutableArray();
+            => [.. _invocationExpression.ArgumentList.Arguments.Select(a => DetermineParameterType(a, cancellationToken))];
 
         private ITypeSymbol DetermineParameterType(ArgumentSyntax argument, CancellationToken cancellationToken)
             => argument.DetermineParameterType(Document.SemanticModel, cancellationToken);
 
         protected override ImmutableArray<bool> DetermineParameterOptionality(CancellationToken cancellationToken)
-            => _invocationExpression.ArgumentList.Arguments.Select(a => false).ToImmutableArray();
+            => [.. _invocationExpression.ArgumentList.Arguments.Select(a => false)];
 
         protected override bool IsIdentifierName()
             => State.SimpleNameOpt.Kind() == SyntaxKind.IdentifierName;

src/Analyzers/CSharp/CodeFixes/InlineDeclaration/CSharpInlineDeclarationCodeFixProvider.cs

@@ -246,7 +246,7 @@ private static ImmutableArray<StatementSyntax> GetStatements(SyntaxNode pseudoBl
             return [.. switchSection.Statements];
 
         if (pseudoBlock is CompilationUnitSyntax compilationUnit)
-            return compilationUnit.Members.OfType<GlobalStatementSyntax>().Select(g => g.Statement).ToImmutableArray();
+            return [.. compilationUnit.Members.OfType<GlobalStatementSyntax>().Select(g => g.Statement)];
 
         return [];
     }

src/Analyzers/CSharp/CodeFixes/MisplacedUsingDirectives/MisplacedUsingDirectivesCodeFixProvider.cs

@@ -227,7 +227,7 @@ private static CompilationUnitSyntax MoveUsingsOutsideNamespaces(CompilationUnit
         var usingsToAdd = namespaceDeclarationMap.Values.SelectMany(result => result.usingsFromNamespace)
             .Select(directive => directive.WithAdditionalAnnotations(Formatter.Annotation, s_warningAnnotation));
 
-        var (deduplicatedUsings, orphanedTrivia) = RemoveDuplicateUsings(compilationUnit.Usings, usingsToAdd.ToImmutableArray());
+        var (deduplicatedUsings, orphanedTrivia) = RemoveDuplicateUsings(compilationUnit.Usings, [.. usingsToAdd]);
 
         // Update the compilation unit with the usings from the namespace declaration.
         var newUsings = compilationUnitWithReplacedNamespaces.Usings.AddRange(deduplicatedUsings);

src/Analyzers/CSharp/CodeFixes/RemoveUnnecessaryImports/CSharpRemoveUnnecessaryImportsCodeFixProvider.cs

@@ -13,6 +13,7 @@ namespace Microsoft.CodeAnalysis.CSharp.RemoveUnnecessaryImports;
 
 [ExportCodeFixProvider(LanguageNames.CSharp, Name = PredefinedCodeFixProviderNames.RemoveUnnecessaryImports), Shared]
 [ExtensionOrder(After = PredefinedCodeFixProviderNames.AddMissingReference)]
+[ExtensionOrder(Before = PredefinedCodeFixProviderNames.ConvertToProgramMain)]
 [method: ImportingConstructor]
 [method: SuppressMessage("RoslynDiagnosticsReliability", "RS0033:Importing constructor should be [Obsolete]", Justification = "Used in test code: https://github.com/dotnet/roslyn/issues/42814")]
 internal sealed class CSharpRemoveUnnecessaryImportsCodeFixProvider() : AbstractRemoveUnnecessaryImportsCodeFixProvider

src/Analyzers/CSharp/CodeFixes/UseLocalFunction/CSharpUseLocalFunctionCodeFixProvider.cs

@@ -114,7 +114,7 @@ protected override async Task FixAllAsync(
             currentRoot = ReplaceReferences(
                 document, currentRoot,
                 delegateType, parameterList,
-                references.Select(node => currentRoot.GetCurrentNode(node)).ToImmutableArray());
+                [.. references.Select(node => currentRoot.GetCurrentNode(node))]);
         }
 
         editor.ReplaceNode(root, currentRoot);

src/Analyzers/CSharp/Tests/ConvertToRecord/ConvertToRecordCodeFixTests.cs

@@ -161,13 +161,13 @@ private class TestAnalyzer : DiagnosticAnalyzer
     {
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
 #pragma warning disable RS0030 // Do not used banned APIs
-            => ImmutableArray.Create(new DiagnosticDescriptor(
+            => [new DiagnosticDescriptor(
                 "CS8865",
                 "Only records may inherit from records.",
                 "Only records may inherit from records.",
                 "Compiler error",
                 DiagnosticSeverity.Error,
-                isEnabledByDefault: true));
+                isEnabledByDefault: true)];
 #pragma warning restore RS0030 // Do not used banned APIs
 
         public override void Initialize(AnalysisContext context)

src/Analyzers/CSharp/Tests/NamingStyles/NamingStylesTests.cs

@@ -272,7 +272,7 @@ class C
             {
                 {{camelCaseSymbol}}
             }
-            """, new TestParameters(options: s_options.AccessibilitiesArePascalCase(ImmutableArray.Create(alternateAccessibility))));
+            """, new TestParameters(options: s_options.AccessibilitiesArePascalCase([alternateAccessibility])));
 
         await TestInRegularAndScriptAsync(
             $$"""
@@ -286,7 +286,7 @@ class C
             {
                 {{pascalCaseSymbol}}
             }
-            """, options: s_options.AccessibilitiesArePascalCase(ImmutableArray.Create(accessibility)));
+            """, options: s_options.AccessibilitiesArePascalCase([accessibility]));
     }
 
     [Fact]