Skip to content

Commit e067c25

Browse files
committed
feedback and cleanup
1 parent 68ed6d9 commit e067c25

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/ExportProviderBuilderTests.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,6 @@ public async Task CanFindCodeBaseWhenReservedCharactersInPath(string reservedCha
8686

8787
var dllPath = GenerateDll(reservedCharacter, out var assemblyName);
8888

89-
var firstServer = await TestLspServer.CreateAsync(new Roslyn.LanguageServer.Protocol.ClientCapabilities(), TestOutputLogger, MefCacheDirectory.Path, includeDevKitComponents: true, [dllPath]);
90-
await firstServer.DisposeAsync();
91-
9289
await using var testServer = await TestLspServer.CreateAsync(new Roslyn.LanguageServer.Protocol.ClientCapabilities(), TestOutputLogger, MefCacheDirectory.Path, includeDevKitComponents: true, [dllPath]);
9390

9491
var assemblies = AppDomain.CurrentDomain.GetAssemblies();

src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/CustomExportAssemblyLoader.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ private Assembly LoadAssemblyFromCodeBase(AssemblyName assemblyName, string code
9696
}
9797

9898
// As described above, we can get a code base URI that contains the unescaped code base file path. This can cause issues when we parse it as a URI if the code base file path
99-
// contains URI reserved characters (for example '#') which are left unescaped in the URI string. While we it is a well formed URI, when System.Uri parses the code base URI
99+
// contains URI reserved characters (for example '#') which are left unescaped in the URI string. While it is a well formed URI, when System.Uri parses the code base URI
100100
// the path component can get mangled and longer accurately represent the actual file system path.
101101
//
102102
// A concrete example - given code base URI 'file:///c:/Learn C#/file.dll', the path component from System.Uri will be 'c:/learn c' and '#/file.dll' is parsed as part of the fragment.

0 commit comments

Comments
 (0)