Skip to content

Remove IQueueItem abstraction and standardize CLSP queue pipeline on QueueItem#82410

Open
Copilot wants to merge 3 commits intomainfrom
copilot/remove-iqueueitem-interface
Open

Remove IQueueItem abstraction and standardize CLSP queue pipeline on QueueItem#82410
Copilot wants to merge 3 commits intomainfrom
copilot/remove-iqueueitem-interface

Conversation

Copy link
Contributor

Copilot AI commented Feb 14, 2026

IQueueItem doesnt seem to be implemented by any of the consumers. Having an interface for it seems unnecessary as it just makes any changes to the queue item more difficult.

Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove IQueueItem interface from clasp library Remove IQueueItem abstraction and standardize CLSP queue pipeline on QueueItem Feb 14, 2026
Copilot AI requested a review from dibarbet February 14, 2026 02:04
@dibarbet
Copy link
Member

@copilot please correct this CI error
src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/QueueItem.cs(162,137): error IDE0060: (NETCORE_ENGINEERING_TELEMETRY=Build) Remove unused parameter 'language' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0060)

Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 14, 2026

@copilot please correct this CI error
src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework/QueueItem.cs(162,137): error IDE0060: (NETCORE_ENGINEERING_TELEMETRY=Build) Remove unused par...

Fixed in 78b5425. I removed the unused language parameter from QueueItem.StartRequestAsync, updated the RequestExecutionQueue call sites, and updated the affected unit test call accordingly.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • vb4vsblobprodcus33.vsblob.vsassets.io
    • Triggering command: /usr/share/dotnet/dotnet dotnet test src/LanguageServer/Microsoft.CommonLanguageServerProtocol.Framework.UnitTests/Microsoft.CommonLanguageServerProtocol.Framework.UnitTests.csproj -f net8.0 --nologo (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@dibarbet dibarbet marked this pull request as ready for review February 15, 2026 01:54
@dibarbet dibarbet requested a review from a team as a code owner February 15, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants