Fix another RuntimeAsync NRE with hoisted methods#82624
Open
333fred wants to merge 6 commits intodotnet:mainfrom
Open
Fix another RuntimeAsync NRE with hoisted methods#82624333fred wants to merge 6 commits intodotnet:mainfrom
333fred wants to merge 6 commits intodotnet:mainfrom
Conversation
As pointed out by @AlekseyTs, `CSharpCompilation.IsRuntimeAsyncEnabledIn` was assuming that only `SourceMethodSymbol`s would be passed in. This isn't true for extension blocks after local rewriting, which indeed caused a crash when a couple of tests were augmented with attribute-level runtime async codegen suppression. To fix, we move the attribute check up to `MethodSymbol` and implement across all of our symbol types. Fixes dotnet#82571.
Member
Author
|
@jcouv @AlekseyTs @dotnet/roslyn-compiler for review |
AlekseyTs
reviewed
Mar 4, 2026
src/Compilers/CSharp/Portable/Symbols/ReducedExtensionMethodSymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Mar 4, 2026
src/Compilers/CSharp/Portable/Symbols/FunctionPointers/FunctionPointerMethodSymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Mar 4, 2026
src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PEMethodSymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Mar 4, 2026
src/ExpressionEvaluator/CSharp/Source/ExpressionCompiler/Symbols/EEMethodSymbol.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Done with review pass (commit 2) #Closed |
jcouv
reviewed
Mar 7, 2026
jcouv
reviewed
Mar 7, 2026
src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenAsyncSpillTests.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Mar 7, 2026
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (commit 2)
Member
Author
|
@AlekseyTs @jcouv I've addressed feedback. I've also renamed the property for clarity, since it's not "whether runtime async is enabled", but is actually "whether there's an attribute that's explicitly controlling runtime async". |
AlekseyTs
reviewed
Mar 10, 2026
Contributor
|
Done with review pass (commit 3) |
jcouv
reviewed
Mar 10, 2026
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (commit 3). Just waiting to see how EE question turns out
AlekseyTs
reviewed
Mar 11, 2026
src/Compilers/CSharp/Portable/Symbols/Wrapped/WrappedMethodSymbol.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Done with review pass (commit 4) |
Member
Author
|
@AlekseyTs @jcouv for another look please. |
AlekseyTs
reviewed
Mar 13, 2026
src/Compilers/CSharp/Portable/Symbols/NativeIntegerTypeSymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Mar 13, 2026
src/Compilers/CSharp/Portable/Symbols/SubstitutedMethodSymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Mar 13, 2026
|
|
||
| public override bool IsAsync => _underlyingMethod.IsAsync; | ||
|
|
||
| internal sealed override ThreeState RuntimeAsyncMethodGenerationAttributeSetting => _underlyingMethod.RuntimeAsyncMethodGenerationAttributeSetting; |
Contributor
AlekseyTs
reviewed
Mar 13, 2026
| get { return _parameters; } | ||
| } | ||
|
|
||
| public override bool IsAsync => _underlyingMethod.IsAsync; |
Contributor
AlekseyTs
reviewed
Mar 13, 2026
| public override bool IsAsync => this.UnderlyingMethod.IsAsync; | ||
| public override ImmutableArray<CustomModifier> RefCustomModifiers => this.UnderlyingMethod.RefCustomModifiers; | ||
| public override TypeWithAnnotations ReturnTypeWithAnnotations => this.UnderlyingMethod.ReturnTypeWithAnnotations; | ||
| internal sealed override ThreeState RuntimeAsyncMethodGenerationAttributeSetting => this.UnderlyingMethod.RuntimeAsyncMethodGenerationAttributeSetting; |
Contributor
Contributor
|
Done with review pass (commit 5) |
Member
Author
|
@AlekseyTs please take another look. |
AlekseyTs
approved these changes
Mar 13, 2026
Contributor
AlekseyTs
left a comment
AlekseyTs
left a comment
There was a problem hiding this comment.
LGTM (commit 6), assuming CI is passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @AlekseyTs,
CSharpCompilation.IsRuntimeAsyncEnabledInwas assuming that onlySourceMethodSymbols would be passed in. This isn't true for extension blocks after local rewriting, which indeed caused a crash when a couple of tests were augmented with attribute-level runtime async codegen suppression. To fix, we move the attribute check up toMethodSymboland implement across all of our symbol types. Fixes #82571.Relates to test plan #75960.