Reduce allocations in normal elfie usage#82743
Merged
ToddGrun merged 2 commits intodotnet:mainfrom Mar 14, 2026
Merged
Conversation
In the binary, non-patch case (aka, the "normal" case), this should prevent a LOH byte[] allocation reading a roughly 15 MB binary file. Instead, use a stream so that the whole file need not be read into memory at once. Will add more details if a speedometer run comes back looking good.
Contributor
Author
|
/pr-val |
Contributor
|
View PR Validation Run triggered by @ToddGrun Parameters
|
Contributor
|
I don't think this is worthwhile. We patch like once every 3 or 6 months. Saving a single LOH allocation in that time isn't really necessary. |
Contributor
Author
That doesn't match what I see when debugging. I see this run on each instance. |
Contributor
|
Ah sorry. I misread. I thought you were saying in the binary-patch case we were seeing the LOH allocation. Reviewing now. |
src/Features/Core/Portable/SymbolSearch/Windows/SymbolSearchUpdateEngine.IOService.cs
Show resolved
Hide resolved
src/Features/Core/Portable/SymbolSearch/Windows/SymbolSearchUpdateEngine.Update.cs
Show resolved
Hide resolved
src/Features/Core/Portable/SymbolSearch/Windows/SymbolSearchUpdateEngine.Update.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Mar 13, 2026
JoeRobich
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the binary, non-patch case (aka, the "normal" case), this should prevent a LOH byte[] allocation reading a roughly 15 MB binary file. Instead, use a stream so that the whole file need not be read into memory at once.
*** old allocations ***
*** new allocations ***
Microsoft Reviewers: Open in CodeFlow