Use new TypeName methods in runtime tools (#115857)

Replace the usage of the TypeNameHelpers utility class with the newer TypeName class methods and properties in the runtime tools.

Co-authored-by: MichalStrehovsky <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]>

Author: Copilot

src/coreclr/tools/Common/TypeSystem/Common/Utilities/CustomAttributeTypeNameParser.cs

@@ -179,21 +179,18 @@ private TypeDesc GetSimpleTypeFromModule(TypeName typeName, ModuleDesc module)
                     TypeDesc type = GetSimpleTypeFromModule(typeName.DeclaringType, module);
                     if (type == null)
                         return null;
-                    return ((MetadataType)type).GetNestedType(TypeNameHelpers.Unescape(typeName.Name));
+                    return ((MetadataType)type).GetNestedType(TypeName.Unescape(typeName.Name));
                 }
 
-                string fullName = TypeNameHelpers.Unescape(typeName.FullName);
-
                 if (_canonGenericResolver != null)
                 {
+                    string fullName = TypeName.Unescape(typeName.FullName);
                     TypeDesc canonType = _canonGenericResolver(module, fullName);
                     if (canonType != null)
                         return canonType;
                 }
 
-                (string typeNamespace, string name) = TypeNameHelpers.Split(fullName);
-
-                return module.GetType(typeNamespace, name, throwIfNotFound: false);
+                return module.GetType(TypeName.Unescape(typeName.Namespace), TypeName.Unescape(typeName.Name), throwIfNotFound: false);
             }
 
             private TypeDesc GetGenericType(TypeName typeName)

src/coreclr/tools/ILVerification/ILVerification.projitems

@@ -66,9 +66,6 @@
     <Compile Include="$(ToolsCommonPath)TypeSystem\Common\Utilities\CustomAttributeTypeNameParser.cs">
       <Link>Utilities\CustomAttributeTypeNameParser.cs</Link>
     </Compile>
-    <Compile Include="$(LibrariesProjectRoot)\Common\src\System\Reflection\Metadata\TypeNameHelpers.cs">
-      <Link>Utilities\TypeNameHelpers.cs</Link>
-    </Compile>
     <Compile Include="$(LibrariesProjectRoot)\Common\src\System\Text\ValueStringBuilder.cs">
       <Link>Utilities\ValueStringBuilder.cs</Link>
     </Compile>

src/coreclr/tools/aot/ILCompiler.Compiler/ILCompiler.Compiler.csproj

@@ -394,9 +394,6 @@
     <Compile Include="Compiler\Dataflow\TrimAnalysisMethodCallPattern.cs" />
     <Compile Include="Compiler\Dataflow\TrimAnalysisPatternStore.cs" />
     <Compile Include="Compiler\Dataflow\TrimAnalysisTokenAccessPattern.cs" />
-    <Compile Include="$(LibrariesProjectRoot)\Common\src\System\Reflection\Metadata\TypeNameHelpers.cs">
-      <Link>Utilities\TypeNameHelpers.cs</Link>
-    </Compile>
     <Compile Include="$(LibrariesProjectRoot)\Common\src\System\Text\ValueStringBuilder.cs">
       <Link>Utilities\ValueStringBuilder.cs</Link>
     </Compile>

src/coreclr/tools/aot/ILCompiler.Trimming.Tests/ILCompiler.Trimming.Tests.csproj

@@ -28,7 +28,6 @@
     <Compile Include="$(ToolsProjectRoot)illink/src/linker/Linker/TypeNameResolver.cs" />
     <Compile Include="$(ToolsProjectRoot)illink/src/linker/Linker/ITryResolve.cs" />
     <Compile Include="$(ToolsProjectRoot)illink/src/linker/Linker/ModuleDefinitionExtensions.cs" />
-    <Compile Include="$(LibrariesProjectRoot)/Common/src/System/Reflection/Metadata/TypeNameHelpers.cs" />
     <Compile Include="$(LibrariesProjectRoot)/Common/src/System/Text/ValueStringBuilder.cs" />
   </ItemGroup>
 

src/coreclr/tools/aot/ILCompiler.TypeSystem/ILCompiler.TypeSystem.csproj

@@ -198,9 +198,6 @@
     <Compile Include="..\..\Common\TypeSystem\Common\Utilities\CustomAttributeTypeNameParser.cs">
       <Link>Utilities\CustomAttributeTypeNameParser.cs</Link>
     </Compile>
-    <Compile Include="$(LibrariesProjectRoot)\Common\src\System\Reflection\Metadata\TypeNameHelpers.cs">
-      <Link>Utilities\TypeNameHelpers.cs</Link>
-    </Compile>
     <Compile Include="$(LibrariesProjectRoot)\Common\src\System\Text\ValueStringBuilder.cs">
       <Link>Utilities\ValueStringBuilder.cs</Link>
     </Compile>

src/libraries/Common/src/System/Reflection/Metadata/TypeNameHelpers.cs

@@ -9,7 +9,6 @@
 using TypeName = System.Reflection.Metadata.TypeName;
 using TypeNameParseOptions = System.Reflection.Metadata.TypeNameParseOptions;
 using AssemblyNameInfo = System.Reflection.Metadata.AssemblyNameInfo;
-using TypeNameHelpers = System.Reflection.Metadata.TypeNameHelpers;
 
 #nullable enable
 
@@ -129,10 +128,10 @@ public bool TryResolveTypeName (
 					TypeDefinition? type = GetSimpleTypeFromModule (typeName.DeclaringType!, module);
 					if (type == null)
 						return null;
-					return GetNestedType (type, TypeNameHelpers.Unescape (typeName.Name));
+					return GetNestedType (type, TypeName.Unescape (typeName.Name));
 				}
 
-				return module.ResolveType (TypeNameHelpers.Unescape (typeName.FullName), _metadataResolver);
+				return module.ResolveType (TypeName.Unescape (typeName.FullName), _metadataResolver);
 			}
 
 			TypeDefinition? GetNestedType (TypeDefinition type, string nestedTypeName)

src/tools/illink/src/linker/Linker/TypeNameResolver.cs

@@ -74,7 +74,6 @@
   <ItemGroup>
     <AdditionalFiles Include="BannedSymbols.txt" />
     <Compile Remove="ref\**\*.cs" />
-    <Compile Include="$(LibrariesProjectRoot)\Common\src\System\Reflection\Metadata\TypeNameHelpers.cs" />
     <Compile Include="$(LibrariesProjectRoot)\Common\src\System\Text\ValueStringBuilder.cs" />
   </ItemGroup>