Skip to content

Commit 316d7ad

Browse files
committed
Revert test expectations
1 parent d207f7d commit 316d7ad

File tree

4 files changed

+25
-25
lines changed

4 files changed

+25
-25
lines changed

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public void Ctor_ExpectedDefaultValues()
4848
using (HttpClientHandler handler = CreateHttpClientHandler())
4949
{
5050
Assert.Null(handler.ServerCertificateCustomValidationCallback);
51-
Assert.True(handler.CheckCertificateRevocationList);
51+
Assert.False(handler.CheckCertificateRevocationList);
5252
}
5353
}
5454

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,9 @@ public void Ctor_ExpectedDefaultPropertyValues()
7676
Assert.False(handler.PreAuthenticate);
7777
Assert.True(handler.SupportsProxy);
7878
Assert.True(handler.SupportsRedirectConfiguration);
79+
Assert.False(handler.CheckCertificateRevocationList);
7980

8081
// Changes from .NET Framework.
81-
Assert.True(handler.CheckCertificateRevocationList);
8282
Assert.Equal(0, handler.MaxRequestContentBufferSize);
8383
Assert.Equal(SslProtocols.None, handler.SslProtocols);
8484
}
@@ -2300,26 +2300,26 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
23002300
switch (headerType)
23012301
{
23022302
case HeaderType.Request:
2303-
{
2304-
var headerLine = DecodeHeaderValue("Custom-Header");
2305-
var receivedHeaderValue = headerLine.Substring(headerLine.IndexOf("HeaderValue"));
2306-
Assert.Equal(headerValue, receivedHeaderValue);
2307-
break;
2308-
}
2303+
{
2304+
var headerLine = DecodeHeaderValue("Custom-Header");
2305+
var receivedHeaderValue = headerLine.Substring(headerLine.IndexOf("HeaderValue"));
2306+
Assert.Equal(headerValue, receivedHeaderValue);
2307+
break;
2308+
}
23092309
case HeaderType.Content:
2310-
{
2311-
var headerLine = DecodeHeaderValue("Custom-Content-Header");
2312-
var receivedHeaderValue = headerLine.Substring(headerLine.IndexOf("HeaderValue"));
2313-
Assert.Equal(headerValue, receivedHeaderValue);
2314-
break;
2315-
}
2310+
{
2311+
var headerLine = DecodeHeaderValue("Custom-Content-Header");
2312+
var receivedHeaderValue = headerLine.Substring(headerLine.IndexOf("HeaderValue"));
2313+
Assert.Equal(headerValue, receivedHeaderValue);
2314+
break;
2315+
}
23162316
case HeaderType.Cookie:
2317-
{
2318-
var headerLine = DecodeHeaderValue("cookie");
2319-
var receivedHeaderValue = headerLine.Substring(headerLine.IndexOf("HeaderValue"));
2320-
Assert.Equal(headerValue, receivedHeaderValue);
2321-
break;
2322-
}
2317+
{
2318+
var headerLine = DecodeHeaderValue("cookie");
2319+
var receivedHeaderValue = headerLine.Substring(headerLine.IndexOf("HeaderValue"));
2320+
Assert.Equal(headerValue, receivedHeaderValue);
2321+
break;
2322+
}
23232323
}
23242324

23252325
string DecodeHeaderValue(string headerName)

src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2540,7 +2540,7 @@ public void SslOptions_GetSet_Roundtrips()
25402540

25412541
Assert.True(options.AllowRenegotiation);
25422542
Assert.Null(options.ApplicationProtocols);
2543-
Assert.Equal(X509RevocationMode.Online, options.CertificateRevocationCheckMode);
2543+
Assert.Equal(X509RevocationMode.NoCheck, options.CertificateRevocationCheckMode);
25442544
Assert.Null(options.ClientCertificates);
25452545
Assert.Equal(SslProtocols.None, options.EnabledSslProtocols);
25462546
Assert.Equal(EncryptionPolicy.RequireEncryption, options.EncryptionPolicy);

src/libraries/System.Net.Security/tests/UnitTests/SslAuthenticationOptionsTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,13 @@ public void EnabledSslProtocols_Get_Set_Succeeds()
133133
[Fact]
134134
public void CheckCertificateRevocation_Get_Set_Succeeds()
135135
{
136-
Assert.Equal(X509RevocationMode.Online, _clientOptions.CertificateRevocationCheckMode);
137-
Assert.Equal(X509RevocationMode.Online, _serverOptions.CertificateRevocationCheckMode);
136+
Assert.Equal(X509RevocationMode.NoCheck, _clientOptions.CertificateRevocationCheckMode);
137+
Assert.Equal(X509RevocationMode.NoCheck, _serverOptions.CertificateRevocationCheckMode);
138138

139-
_clientOptions.CertificateRevocationCheckMode = X509RevocationMode.NoCheck;
139+
_clientOptions.CertificateRevocationCheckMode = X509RevocationMode.Online;
140140
_serverOptions.CertificateRevocationCheckMode = X509RevocationMode.Offline;
141141

142-
Assert.Equal(X509RevocationMode.NoCheck, _clientOptions.CertificateRevocationCheckMode);
142+
Assert.Equal(X509RevocationMode.Online, _clientOptions.CertificateRevocationCheckMode);
143143
Assert.Equal(X509RevocationMode.Offline, _serverOptions.CertificateRevocationCheckMode);
144144

145145
Assert.Throws<ArgumentException>(() => _clientOptions.CertificateRevocationCheckMode = (X509RevocationMode)3);

0 commit comments

Comments
 (0)