Don't run RangeCheck if no GT_BOUNDS_CHECK were seen (#112512)

Author: EgorBo

src/coreclr/jit/compiler.h

@@ -7578,6 +7578,7 @@ class Compiler
 #define OMF_HAS_RECURSIVE_TAILCALL             0x00040000 // Method contains recursive tail call
 #define OMF_HAS_EXPANDABLE_CAST                0x00080000 // Method contains casts eligible for late expansion
 #define OMF_HAS_STACK_ARRAY                    0x00100000 // Method contains stack allocated arrays
+#define OMF_HAS_BOUNDS_CHECKS                  0x00200000 // Method contains bounds checks
 
     // clang-format on
 
@@ -7618,6 +7619,16 @@ class Compiler
         optMethodFlags |= OMF_HAS_STATIC_INIT;
     }
 
+    bool doesMethodHaveBoundsChecks()
+    {
+        return (optMethodFlags & OMF_HAS_BOUNDS_CHECKS) != 0;
+    }
+
+    void setMethodHasBoundsChecks()
+    {
+        optMethodFlags |= OMF_HAS_BOUNDS_CHECKS;
+    }
+
     bool doesMethodHaveExpandableCasts()
     {
         return (optMethodFlags & OMF_HAS_EXPANDABLE_CAST) != 0;

src/coreclr/jit/morph.cpp

@@ -8693,7 +8693,7 @@ GenTree* Compiler::fgMorphSmpOp(GenTree* tree, MorphAddrContext* mac, bool* optA
             break;
 
         case GT_BOUNDS_CHECK:
-
+            setMethodHasBoundsChecks();
             fgAddCodeRef(compCurBB, tree->AsBoundsChk()->gtThrowKind);
             break;
 

src/coreclr/jit/rangecheck.cpp

@@ -14,6 +14,11 @@
 //
 PhaseStatus Compiler::rangeCheckPhase()
 {
+    if (!doesMethodHaveBoundsChecks() || (fgSsaPassesCompleted == 0))
+    {
+        return PhaseStatus::MODIFIED_NOTHING;
+    }
+
     RangeCheck rc(this);
     const bool madeChanges = rc.OptimizeRangeChecks();
     return madeChanges ? PhaseStatus::MODIFIED_EVERYTHING : PhaseStatus::MODIFIED_NOTHING;
@@ -1711,11 +1716,6 @@ void RangeCheck::MapMethodDefs()
 // Entry point to range check optimizations.
 bool RangeCheck::OptimizeRangeChecks()
 {
-    if (m_pCompiler->fgSsaPassesCompleted == 0)
-    {
-        return false;
-    }
-
     bool madeChanges = false;
 
     // Walk through trees looking for arrBndsChk node and check if it can be optimized.

src/coreclr/jit/valuenum.cpp

@@ -15074,8 +15074,8 @@ void Compiler::vnPrint(ValueNum vn, unsigned level)
 
 // Methods of ValueNumPair.
 ValueNumPair::ValueNumPair()
-    : m_liberal(ValueNumStore::NoVN)
-    , m_conservative(ValueNumStore::NoVN)
+    : m_conservative(ValueNumStore::NoVN)
+    , m_liberal(ValueNumStore::NoVN)
 {
 }
 

src/coreclr/jit/valuenumtype.h

@@ -34,8 +34,8 @@ enum ValueNumKind
 struct ValueNumPair
 {
 private:
-    ValueNum m_liberal;
     ValueNum m_conservative;
+    ValueNum m_liberal;
 
 public:
     ValueNum GetLiberal() const
@@ -116,8 +116,8 @@ struct ValueNumPair
     ValueNumPair();
 
     ValueNumPair(ValueNum lib, ValueNum cons)
-        : m_liberal(lib)
-        , m_conservative(cons)
+        : m_conservative(cons)
+        , m_liberal(lib)
     {
     }