Refactor DbgTransportTarget usage to eliminate dynamic allocation. (#122011)

Remove unused interface and header.

Author: AaronRobinsonMSFT

src/coreclr/debug/di/cordb.cpp

@@ -232,11 +232,7 @@ BOOL WINAPI DbgDllMain(HINSTANCE hInstance, DWORD dwReason, LPVOID lpReserved)
 #endif
 
 #if defined(FEATURE_DBGIPC_TRANSPORT_DI)
-            g_pDbgTransportTarget = new (nothrow) DbgTransportTarget();
-            if (g_pDbgTransportTarget == NULL)
-                return FALSE;
-
-            if (FAILED(g_pDbgTransportTarget->Init()))
+            if (FAILED(g_DbgTransportTarget.Init()))
                 return FALSE;
 #endif // FEATURE_DBGIPC_TRANSPORT_DI
         }
@@ -262,12 +258,7 @@ BOOL WINAPI DbgDllMain(HINSTANCE hInstance, DWORD dwReason, LPVOID lpReserved)
         case DLL_PROCESS_DETACH:
         {
 #if defined(FEATURE_DBGIPC_TRANSPORT_DI)
-            if (g_pDbgTransportTarget != NULL)
-            {
-                g_pDbgTransportTarget->Shutdown();
-                delete g_pDbgTransportTarget;
-                g_pDbgTransportTarget = NULL;
-            }
+            g_DbgTransportTarget.Shutdown();
 #endif // FEATURE_DBGIPC_TRANSPORT_DI
         }
         break;

src/coreclr/debug/di/dbgtransportmanager.cpp

@@ -4,13 +4,10 @@
 #include "stdafx.h"
 #include "dbgtransportsession.h"
 #include "dbgtransportmanager.h"
-#include "coreclrremotedebugginginterfaces.h"
-
-
 
 #ifdef FEATURE_DBGIPC_TRANSPORT_DI
 
-DbgTransportTarget *g_pDbgTransportTarget = NULL;
+DbgTransportTarget g_DbgTransportTarget{};
 
 DbgTransportTarget::DbgTransportTarget()
     : m_pProcessList{}

src/coreclr/debug/di/dbgtransportmanager.h

@@ -7,9 +7,6 @@
 
 #ifdef FEATURE_DBGIPC_TRANSPORT_DI
 
-#include "coreclrremotedebugginginterfaces.h"
-
-
 // TODO: Ideally we'd like to remove this class and don't do any process related book keeping in DBI.
 
 // This is a registry of all the processes a debugger knows about, different components call it in order to
@@ -82,7 +79,7 @@ class DbgTransportTarget
     ProcessEntry *LocateProcessByPID(DWORD dwPID);
 };
 
-extern DbgTransportTarget *g_pDbgTransportTarget;
+extern DbgTransportTarget g_DbgTransportTarget;
 
 #endif // FEATURE_DBGIPC_TRANSPORT_DI
 

src/coreclr/debug/di/dbgtransportpipeline.cpp

@@ -209,7 +209,7 @@ HRESULT DbgTransportPipeline::CreateProcessUnderDebugger(
     // Connect to the debugger proxy on the remote machine and ask it to create a process for us.
     HRESULT hr  = E_FAIL;
 
-    m_pProxy = g_pDbgTransportTarget;
+    m_pProxy = &g_DbgTransportTarget;
     hr = m_pProxy->CreateProcess(lpApplicationName,
                                  lpCommandLine,
                                  lpProcessAttributes,
@@ -291,7 +291,7 @@ HRESULT DbgTransportPipeline::DebugActiveProcess(MachineInfo machineInfo, const
 
     HRESULT hr = E_FAIL;
 
-    m_pProxy = g_pDbgTransportTarget;
+    m_pProxy = &g_DbgTransportTarget;
 
     // Establish a connection to the actual runtime to be debugged.
     hr = m_pProxy->GetTransportForProcess(&processDescriptor, &m_pTransport, &m_hProcess);

src/coreclr/debug/di/remoteeventchannel.cpp

@@ -101,7 +101,7 @@ HRESULT NewEventChannelForThisPlatform(CORDB_ADDRESS pLeftSideDCB,
     RemoteEventChannel *      pEventChannel = NULL;
     DebuggerIPCControlBlock * pDCBBuffer    = NULL;
 
-    DbgTransportTarget *   pProxy     = g_pDbgTransportTarget;
+    DbgTransportTarget *   pProxy     = &g_DbgTransportTarget;
     DbgTransportSession *  pTransport = NULL;
 
     hr = pProxy->GetTransportForProcess(pProcessDescriptor, &pTransport, &hDummy);

src/coreclr/debug/di/shimremotedatatarget.cpp

@@ -169,7 +169,7 @@ HRESULT BuildPlatformSpecificDataTarget(MachineInfo machineInfo,
     HRESULT hr = E_FAIL;
 
     ShimRemoteDataTarget * pRemoteDataTarget = NULL;
-    DbgTransportTarget *   pProxy = g_pDbgTransportTarget;
+    DbgTransportTarget *   pProxy = &g_DbgTransportTarget;
     DbgTransportSession *  pTransport = NULL;
 
     hr = pProxy->GetTransportForProcess(pProcessDescriptor, &pTransport, &hDummy);