Delete ECHash (#117861)

We do not need FCall entrypoint to MethodDesc reverse mappinng now that there are no FCall with HelperMethodFrames

Author: jkotas

src/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs

@@ -1583,8 +1583,7 @@ internal static void ValidateObject(object obj, IntPtr pMD)
         internal static partial void ValidateByref(IntPtr byref, IntPtr pMD); // the byref is pinned so we can safely "cast" it to IntPtr
 
         [Intrinsic]
-        [MethodImpl(MethodImplOptions.InternalCall)]
-        internal static extern IntPtr GetStubContext();
+        internal static IntPtr GetStubContext() => throw new UnreachableException(); // Unconditionally expanded intrinsic
 
         [MethodImpl(MethodImplOptions.NoInlining)]
         internal static void MulticastDebuggerTraceHelper(object o, int count)
@@ -1596,11 +1595,10 @@ internal static void MulticastDebuggerTraceHelper(object o, int count)
         private static partial void MulticastDebuggerTraceHelperQCall(ObjectHandleOnStack obj, int count);
 
         [Intrinsic]
-        [MethodImpl(MethodImplOptions.InternalCall)]
-        internal static extern IntPtr NextCallReturnAddress();
+        internal static IntPtr NextCallReturnAddress() => throw new UnreachableException(); // Unconditionally expanded intrinsic
 
         [Intrinsic]
-        internal static Continuation? AsyncCallContinuation() => null;
+        internal static Continuation? AsyncCallContinuation() => throw new UnreachableException(); // Unconditionally expanded intrinsic
     }  // class StubHelpers
 
 #if FEATURE_COMINTEROP

src/coreclr/debug/daccess/reimpl.cpp

@@ -38,9 +38,9 @@ DacGetThread(ULONG32 osThread)
         UNREACHABLE();
     }
 
-    // Note that if we had access to TLS, we could get this at index gThreadTLSIndex for the specified
-    // thread.  However, this is the only place we might want to use TLS, and it's not performance critical,
-    // so we haven't added TLS support to ICorDebugDataTarget (the legacy ICLRDataTarget interface has it though)
+    // Note that if we had access to TLS, we could get this at TLS for the specified thread.  However, this is
+    // the only place we might want to use TLS, and it's not performance critical, so we haven't added TLS support
+    // to ICorDebugDataTarget (the legacy ICLRDataTarget interface has it though)
 
     // Scan the whole thread store to see if there's a matching thread.
 

src/coreclr/debug/ee/dactable.cpp

@@ -22,12 +22,7 @@
 
 #ifdef DEBUGGING_SUPPORTED
 
-extern PTR_ECHash gFCallMethods[FCALL_HASH_SIZE];
-extern TADDR gLowestFCall;
-extern TADDR gHighestFCall;
 extern PCODE g_FCDynamicallyAssignedImplementations[ECall::NUM_DYNAMICALLY_ASSIGNED_FCALL_IMPLEMENTATIONS];
-extern DWORD gThreadTLSIndex;
-extern DWORD gAppDomainTLSIndex;
 extern "C" void STDCALL ThePreStubPatchLabel(void);
 
 #ifdef FEATURE_COMWRAPPERS

src/coreclr/inc/daccess.h

@@ -290,9 +290,9 @@
 //
 //     SystemDomain::m_appDomainIndexList;
 //
-//     extern DWORD gThreadTLSIndex;
+//     extern DWORD g_TlsIndex;
 //
-//     DWORD gThreadTLSIndex = TLS_OUT_OF_INDEXES;
+//     DWORD g_TlsIndex = TLS_OUT_OF_INDEXES;
 //
 // Modified Code:
 //
@@ -312,9 +312,9 @@
 //
 //     SVAL_IMPL(ArrayListStatic, SystemDomain, m_appDomainIndexList);
 //
-//     GVAL_DECL(DWORD, gThreadTLSIndex);
+//     GVAL_DECL(DWORD, g_TlsIndex);
 //
-//     GVAL_IMPL_INIT(DWORD, gThreadTLSIndex, TLS_OUT_OF_INDEXES);
+//     GVAL_IMPL_INIT(DWORD, g_TlsIndex, TLS_OUT_OF_INDEXES);
 //
 // When declaring the variable, the first argument declares the
 // variable's type and the second argument declares the variable's

src/coreclr/inc/dacvars.h

@@ -195,10 +195,6 @@ DEFINE_DACVAR(BOOL, Debugger__s_fCanChangeNgenFlags, Debugger::s_fCanChangeNgenF
 DEFINE_DACVAR(PTR_DebuggerPatchTable, DebuggerController__g_patches, DebuggerController::g_patches)
 DEFINE_DACVAR(BOOL, DebuggerController__g_patchTableValid, DebuggerController::g_patchTableValid)
 
-DEFINE_DACVAR(SIZE_T, dac__gLowestFCall, ::gLowestFCall)
-DEFINE_DACVAR(SIZE_T, dac__gHighestFCall, ::gHighestFCall)
-DEFINE_DACVAR(SIZE_T, dac__gFCallMethods, ::gFCallMethods)
-
 DEFINE_DACVAR(PTR_SyncTableEntry, dac__g_pSyncTable, ::g_pSyncTable)
 #ifdef FEATURE_COMINTEROP
 DEFINE_DACVAR(UNKNOWN_POINTER_TYPE, dac__g_pRCWCleanupList, ::g_pRCWCleanupList)

src/coreclr/vm/ceeload.cpp

@@ -4609,8 +4609,6 @@ void Module::EnumMemoryRegions(CLRDataEnumMemoryFlags flags,
         }
     }
 
-    ECall::EnumFCallMethods();
-
 #ifdef FEATURE_METADATA_UPDATER
     m_ClassList.EnumMemoryRegions();
 

src/coreclr/vm/ceemain.cpp

@@ -825,9 +825,6 @@ void EEStartupHelper()
         // Static initialization
         SystemDomain::Attach();
 
-        // Start up the EE initializing all the global variables
-        ECall::Init();
-
         COMDelegate::Init();
 
         ExecutionManager::Init();

src/coreclr/vm/comdependenthandle.cpp

@@ -43,7 +43,6 @@ extern "C" OBJECTHANDLE QCALLTYPE DependentHandle_InternalAllocWithGCTransition(
 FCIMPL1(Object*, DependentHandle::InternalGetTarget, OBJECTHANDLE handle)
 {
     FCALL_CONTRACT;
-    FCUnique(0x54);
 
     _ASSERTE(handle != NULL);