Skip to content

Commit b82b2b3

Browse files
am11am11
committed
Fix SYSLIB1092 in corelib
1 parent 2c8bf45 commit b82b2b3

File tree

11 files changed

+31
-31
lines changed

11 files changed

+31
-31
lines changed

‎src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/RuntimeModuleBuilder.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ private int GetMemberRef(Module? refedModule, int tr, int defToken)
113113
}
114114

115115
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ModuleBuilder_GetMemberRefFromSignature", StringMarshalling = StringMarshalling.Utf16)]
116-
private static partial int GetMemberRefFromSignature(QCallModule module, int tr, string methodName, byte[] signature, int length);
116+
private static partial int GetMemberRefFromSignature(QCallModule module, int tr, string methodName, [In] byte[] signature, int length);
117117

118118
private int GetMemberRefFromSignature(int tr, string methodName, byte[] signature, int length)
119119
{
@@ -156,7 +156,7 @@ private int GetMemberRefOfFieldInfo(int tkType, RuntimeTypeHandle declaringType,
156156
}
157157

158158
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ModuleBuilder_GetTokenFromTypeSpec")]
159-
private static partial int GetTokenFromTypeSpec(QCallModule pModule, byte[] signature, int length);
159+
private static partial int GetTokenFromTypeSpec(QCallModule pModule, [In] byte[] signature, int length);
160160

161161
private int GetTokenFromTypeSpec(byte[] signature, int length)
162162
{
@@ -165,13 +165,13 @@ private int GetTokenFromTypeSpec(byte[] signature, int length)
165165
}
166166

167167
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ModuleBuilder_GetArrayMethodToken", StringMarshalling = StringMarshalling.Utf16)]
168-
private static partial int GetArrayMethodToken(QCallModule module, int tkTypeSpec, string methodName, byte[] signature, int sigLength);
168+
private static partial int GetArrayMethodToken(QCallModule module, int tkTypeSpec, string methodName, [In] byte[] signature, int sigLength);
169169

170170
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ModuleBuilder_GetStringConstant", StringMarshalling = StringMarshalling.Utf16)]
171171
private static partial int GetStringConstant(QCallModule module, string str, int length);
172172

173173
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ModuleBuilder_SetFieldRVAContent")]
174-
internal static partial void SetFieldRVAContent(QCallModule module, int fdToken, byte[]? data, int length);
174+
internal static partial void SetFieldRVAContent(QCallModule module, int fdToken, [In] byte[]? data, int length);
175175

176176
#endregion
177177

‎src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/RuntimeTypeBuilder.cs‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -66,23 +66,23 @@ public void Bake(RuntimeModuleBuilder module, int token)
6666

6767
#region Internal Static FCalls
6868
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineMethod", StringMarshalling = StringMarshalling.Utf16)]
69-
internal static partial int DefineMethod(QCallModule module, int tkParent, string name, byte[] signature, int sigLength,
69+
internal static partial int DefineMethod(QCallModule module, int tkParent, string name, [In] byte[] signature, int sigLength,
7070
MethodAttributes attributes);
7171

7272
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineMethodSpec")]
73-
internal static partial int DefineMethodSpec(QCallModule module, int tkParent, byte[] signature, int sigLength);
73+
internal static partial int DefineMethodSpec(QCallModule module, int tkParent, [In] byte[] signature, int sigLength);
7474

7575
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineField", StringMarshalling = StringMarshalling.Utf16)]
76-
internal static partial int DefineField(QCallModule module, int tkParent, string name, byte[] signature, int sigLength,
76+
internal static partial int DefineField(QCallModule module, int tkParent, string name, [In] byte[] signature, int sigLength,
7777
FieldAttributes attributes);
7878

7979
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_SetMethodIL")]
8080
private static partial void SetMethodIL(QCallModule module, int tk, [MarshalAs(UnmanagedType.Bool)] bool isInitLocals,
81-
byte[]? body, int bodyLength,
82-
byte[] LocalSig, int sigLength,
81+
[In] byte[]? body, int bodyLength,
82+
[In] byte[] LocalSig, int sigLength,
8383
int maxStackSize,
84-
ExceptionHandler[]? exceptions, int numExceptions,
85-
int[]? tokenFixups, int numTokenFixups);
84+
[In] ExceptionHandler[]? exceptions, int numExceptions,
85+
[In] int[]? tokenFixups, int numTokenFixups);
8686

8787
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineCustomAttribute")]
8888
private static partial void DefineCustomAttribute(QCallModule module, int tkAssociate, int tkConstructor,
@@ -97,7 +97,7 @@ internal static void DefineCustomAttribute(RuntimeModuleBuilder module, int tkAs
9797

9898
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineProperty", StringMarshalling = StringMarshalling.Utf16)]
9999
internal static partial int DefineProperty(QCallModule module, int tkParent, string name, PropertyAttributes attributes,
100-
byte[] signature, int sigLength);
100+
[In] byte[] signature, int sigLength);
101101

102102
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineEvent", StringMarshalling = StringMarshalling.Utf16)]
103103
internal static partial int DefineEvent(QCallModule module, int tkParent, string name, EventAttributes attributes, int tkEventType);
@@ -117,7 +117,7 @@ internal static partial int SetParamInfo(QCallModule module, int tkMethod, int i
117117
ParameterAttributes iParamAttributes, string? strParamName);
118118

119119
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_GetTokenFromSig")]
120-
internal static partial int GetTokenFromSig(QCallModule module, byte[] signature, int sigLength);
120+
internal static partial int GetTokenFromSig(QCallModule module, [In] byte[] signature, int sigLength);
121121

122122
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_SetFieldLayoutOffset")]
123123
internal static partial void SetFieldLayoutOffset(QCallModule module, int fdToken, int iOffset);
@@ -535,11 +535,11 @@ protected override bool IsCreatedCore()
535535
#region FCalls
536536
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineType", StringMarshalling = StringMarshalling.Utf16)]
537537
private static partial int DefineType(QCallModule module,
538-
string fullname, int tkParent, TypeAttributes attributes, int tkEnclosingType, int[] interfaceTokens);
538+
string fullname, int tkParent, TypeAttributes attributes, int tkEnclosingType, [In] int[] interfaceTokens);
539539

540540
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineGenericParam", StringMarshalling = StringMarshalling.Utf16)]
541541
private static partial int DefineGenericParam(QCallModule module,
542-
string name, int tkParent, GenericParameterAttributes attributes, int position, int[] constraints);
542+
string name, int tkParent, GenericParameterAttributes attributes, int position, [In] int[] constraints);
543543

544544
[LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_TermCreateClass")]
545545
private static partial void TermCreateClass(QCallModule module, int tk, ObjectHandleOnStack type);

‎src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1773,7 +1773,7 @@ public bool Equals(ModuleHandle handle)
17731773
private static partial void GetDynamicMethod(
17741774
QCallModule module,
17751775
string name,
1776-
byte[] sig,
1776+
[In] byte[] sig,
17771777
int sigLen,
17781778
ObjectHandleOnStack resolver,
17791779
ObjectHandleOnStack result);

‎src/libraries/Common/src/Interop/Interop.Calendar.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ internal static partial class Interop
1010
internal static partial class Globalization
1111
{
1212
[LibraryImport(Libraries.GlobalizationNative, EntryPoint = "GlobalizationNative_GetCalendars", StringMarshalling = StringMarshalling.Utf16)]
13-
internal static partial int GetCalendars(string localeName, CalendarId[] calendars, int calendarsCapacity);
13+
internal static partial int GetCalendars(string localeName, [Out] CalendarId[] calendars, int calendarsCapacity);
1414

1515
[LibraryImport(Libraries.GlobalizationNative, EntryPoint = "GlobalizationNative_GetCalendarInfo", StringMarshalling = StringMarshalling.Utf16)]
1616
internal static unsafe partial ResultCode GetCalendarInfo(string localeName, CalendarId calendarId, CalendarDataType calendarDataType, char* result, int resultCapacity);

‎src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetUnixVersion.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ internal static partial class Interop
1212
internal static partial class Sys
1313
{
1414
[LibraryImport(Libraries.SystemNative, EntryPoint = "SystemNative_GetUnixVersion", StringMarshalling = StringMarshalling.Utf8, SetLastError = true)]
15-
private static partial int GetUnixVersion(byte[] version, ref int capacity);
15+
private static partial int GetUnixVersion([Out] byte[] version, ref int capacity);
1616

1717
internal static string GetUnixVersion()
1818
{

‎src/libraries/Common/src/Interop/Windows/Advapi32/Interop.CreateWellKnownSid.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ internal static partial class Advapi32
1515
[LibraryImport(Libraries.Advapi32, SetLastError = true)]
1616
internal static partial int CreateWellKnownSid(
1717
int sidType,
18-
byte[]? domainSid,
19-
byte[] resultSid,
18+
[In] byte[]? domainSid,
19+
[Out] byte[] resultSid,
2020
ref uint resultSidLength);
2121

2222
[LibraryImport(Libraries.Advapi32, SetLastError = true)]

‎src/libraries/Common/src/Interop/Windows/Advapi32/Interop.RegEnumKeyEx.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ internal static unsafe partial int RegEnumKeyEx(
1818
int dwIndex,
1919
ref char lpName,
2020
ref int lpcbName,
21-
int[]? lpReserved,
21+
[In] int[]? lpReserved,
2222
[Out] char[]? lpClass,
23-
int[]? lpcbClass,
24-
long[]? lpftLastWriteTime);
23+
[In, Out] int[]? lpcbClass,
24+
[Out] long[]? lpftLastWriteTime);
2525
}
2626
}

‎src/libraries/Common/src/Interop/Windows/Advapi32/Interop.RegEnumValue.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ internal static partial int RegEnumValue(
2020
[Out] char[] lpValueName,
2121
ref int lpcbValueName,
2222
IntPtr lpReserved_MustBeZero,
23-
int[]? lpType,
24-
byte[]? lpData,
25-
int[]? lpcbData);
23+
[Out] int[]? lpType,
24+
[Out] byte[]? lpData,
25+
[In, Out] int[]? lpcbData);
2626
}
2727
}

‎src/libraries/Common/src/Interop/Windows/Advapi32/Interop.RegQueryValueEx.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ internal static partial class Advapi32
1616
internal static partial int RegQueryValueEx(
1717
SafeRegistryHandle hKey,
1818
string? lpValueName,
19-
int[]? lpReserved,
19+
[In] int[]? lpReserved,
2020
ref int lpType,
21-
byte[]? lpData,
21+
[Out] byte[]? lpData,
2222
ref int lpcbData);
2323

2424
[LibraryImport(Libraries.Advapi32, EntryPoint = "RegQueryValueExW", StringMarshalling = StringMarshalling.Utf16)]

‎src/libraries/Common/src/Interop/Windows/Advapi32/Interop.RegSetValueEx.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ internal static partial int RegSetValueEx(
1818
string? lpValueName,
1919
int Reserved,
2020
int dwType,
21-
byte[]? lpData,
21+
[In] byte[]? lpData,
2222
int cbData);
2323

2424
[LibraryImport(Libraries.Advapi32, EntryPoint = "RegSetValueExW", StringMarshalling = StringMarshalling.Utf16)]
@@ -27,7 +27,7 @@ internal static partial int RegSetValueEx(
2727
string? lpValueName,
2828
int Reserved,
2929
int dwType,
30-
char[]? lpData,
30+
[In] char[]? lpData,
3131
int cbData);
3232

3333
[LibraryImport(Libraries.Advapi32, EntryPoint = "RegSetValueExW", StringMarshalling = StringMarshalling.Utf16)]

0 commit comments

Comments
 (0)