Skip to content

Commit cb5431d

Browse files
authored
Small pgo cleanup (#48145)
On the runtime side, intitialize the schema field so that the jit does not internally think all optimized builds have pgo data with mismatched IL. Quiet down some of the jit dumping when doing edge instrumentation. Remove a few unused COMPlus vars from the jit.
1 parent acdb869 commit cb5431d

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

src/coreclr/jit/fgprofile.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -904,17 +904,14 @@ class EfficientEdgeCountInstrumentor : public Instrumentor, public SpanningTreeV
904904
{
905905
m_blockCount++;
906906
block->bbSparseProbeList = nullptr;
907-
JITDUMP("node " FMT_BB "\n", block->bbNum);
908907
}
909908

910909
void VisitTreeEdge(BasicBlock* source, BasicBlock* target) override
911910
{
912-
JITDUMP("tree " FMT_BB " -> " FMT_BB "\n", source->bbNum, target->bbNum);
913911
}
914912

915913
void VisitNonTreeEdge(BasicBlock* source, BasicBlock* target, SpanningTreeVisitor::EdgeKind kind) override
916914
{
917-
JITDUMP("non-tree " FMT_BB " -> " FMT_BB "\n", source->bbNum, target->bbNum);
918915
switch (kind)
919916
{
920917
case EdgeKind::PostdominatesSource:

src/coreclr/jit/jitconfigvalues.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -445,9 +445,7 @@ CONFIG_INTEGER(JitEnableGuardedDevirtualization, W("JitEnableGuardedDevirtualiza
445445
#if defined(DEBUG)
446446
// Various policies for GuardedDevirtualization
447447
CONFIG_STRING(JitGuardedDevirtualizationRange, W("JitGuardedDevirtualizationRange"))
448-
CONFIG_INTEGER(JitGuardedDevirtualizationGuessUniqueInterface, W("JitGuardedDevirtualizationGuessUniqueInterface"), 1)
449448
CONFIG_INTEGER(JitGuardedDevirtualizationGuessBestClass, W("JitGuardedDevirtualizationGuessBestClass"), 1)
450-
CONFIG_INTEGER(JitGuardedDeivrtualizationUseProfile, W("JitGuardedDevirtualizationUseProfile"), 0)
451449
#endif // DEBUG
452450

453451
// Enable insertion of patchpoints into Tier0 methods with loops.

src/coreclr/vm/jitinterface.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -946,7 +946,7 @@ protected :
946946
ComputedPgoData* m_next = nullptr;
947947
MethodDesc *m_pMD;
948948
NewArrayHolder<BYTE> m_allocatedData;
949-
PgoInstrumentationSchema* m_schema;
949+
PgoInstrumentationSchema* m_schema = nullptr;
950950
UINT32 m_cSchemaElems;
951951
BYTE *m_pInstrumentationData = nullptr;
952952
HRESULT m_hr = E_NOTIMPL;

0 commit comments

Comments
 (0)