Skip to content

Commit dc1a94b

Browse files
authored
Merge pull request #110336 from dotnet/merge/release/8.0-to-release/8.0-staging
[automated] Merge branch 'release/8.0' => 'release/8.0-staging'
2 parents 430dcc9 + b704dce commit dc1a94b

File tree

4 files changed

+29
-8
lines changed

4 files changed

+29
-8
lines changed

eng/Versions.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<Project>
22
<PropertyGroup>
33
<!-- The .NET product branding version -->
4-
<ProductVersion>8.0.12</ProductVersion>
4+
<ProductVersion>8.0.13</ProductVersion>
55
<!-- File version numbers -->
66
<MajorVersion>8</MajorVersion>
77
<MinorVersion>0</MinorVersion>
8-
<PatchVersion>12</PatchVersion>
8+
<PatchVersion>13</PatchVersion>
99
<SdkBandVersion>8.0.100</SdkBandVersion>
1010
<PackageVersionNet7>7.0.20</PackageVersionNet7>
1111
<PackageVersionNet6>6.0.36</PackageVersionNet6>

src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,23 @@ static MsQuicApi()
8585

8686
if (OperatingSystem.IsWindows())
8787
{
88-
// Windows ships msquic in the assembly directory.
89-
loaded = NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle);
88+
#pragma warning disable IL3000 // Avoid accessing Assembly file path when publishing as a single file
89+
// Windows ships msquic in the assembly directory next to System.Net.Quic, so load that.
90+
// For single-file deployments, the assembly location is an empty string so we fall back
91+
// to AppContext.BaseDirectory which is the directory containing the single-file executable.
92+
string path = typeof(MsQuicApi).Assembly.Location is string assemblyLocation && !string.IsNullOrEmpty(assemblyLocation)
93+
? System.IO.Path.GetDirectoryName(assemblyLocation)!
94+
: AppContext.BaseDirectory;
95+
#pragma warning restore IL3000
96+
97+
path = System.IO.Path.Combine(path, Interop.Libraries.MsQuic);
98+
99+
if (NetEventSource.Log.IsEnabled())
100+
{
101+
NetEventSource.Info(null, $"Attempting to load MsQuic from {path}");
102+
}
103+
104+
loaded = NativeLibrary.TryLoad(path, typeof(MsQuicApi).Assembly, DllImportSearchPath.LegacyBehavior, out msQuicHandle);
90105
}
91106
else
92107
{
@@ -156,7 +171,7 @@ static MsQuicApi()
156171

157172
if (version < s_minMsQuicVersion)
158173
{
159-
NotSupportedReason = $"Incompatible MsQuic library version '{version}', expecting higher than '{s_minMsQuicVersion}'.";
174+
NotSupportedReason = $"Incompatible MsQuic library version '{version}', expecting higher than '{s_minMsQuicVersion}'.";
160175
if (NetEventSource.Log.IsEnabled())
161176
{
162177
NetEventSource.Info(null, NotSupportedReason);
@@ -180,7 +195,7 @@ static MsQuicApi()
180195
// Implies windows platform, check TLS1.3 availability
181196
if (!IsWindowsVersionSupported())
182197
{
183-
NotSupportedReason = $"Current Windows version ({Environment.OSVersion}) is not supported by QUIC. Minimal supported version is {s_minWindowsVersion}.";
198+
NotSupportedReason = $"Current Windows version ({Environment.OSVersion}) is not supported by QUIC. Minimal supported version is {s_minWindowsVersion}.";
184199
if (NetEventSource.Log.IsEnabled())
185200
{
186201
NetEventSource.Info(null, NotSupportedReason);

src/mono/wasm/build/WasmApp.targets

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@
207207
<!-- Use a unique property, so the already run wasm targets can also run -->
208208
<MSBuild Projects="$(MSBuildProjectFile)"
209209
Targets="WasmNestedPublishApp"
210-
Properties="_WasmInNestedPublish_UniqueProperty_XYZ=true;;WasmBuildingForNestedPublish=true;DeployOnBuild=;_IsPublishing=;_WasmIsPublishing=$(_IsPublishing)">
210+
Properties="_WasmInNestedPublish_UniqueProperty_XYZ=true;;WasmBuildingForNestedPublish=true;DeployOnBuild=;_IsPublishing=;_WasmIsPublishing=$(_IsPublishing);ResolveAssemblyReferencesFindRelatedSatellites=true">
211211
<Output TaskParameter="TargetOutputs" ItemName="WasmNestedPublishAppResultItems" />
212212
</MSBuild>
213213

@@ -503,6 +503,7 @@
503503
<Target Name="_AfterWasmBuildApp">
504504
<ItemGroup>
505505
<WasmAssembliesFinal Include="@(_WasmAssembliesInternal)" LlvmBitCodeFile="" />
506+
<WasmAssembliesFinal Include="@(_WasmSatelliteAssemblies)" />
506507
</ItemGroup>
507508
</Target>
508509
</Project>

src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmBuildAssets.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,12 @@ public override bool Execute()
111111
assetCandidate.SetMetadata("AssetTraitName", "Culture");
112112
assetCandidate.SetMetadata("AssetTraitValue", inferredCulture);
113113
assetCandidate.SetMetadata("RelativePath", $"_framework/{inferredCulture}/{satelliteAssembly.GetMetadata("FileName")}{satelliteAssembly.GetMetadata("Extension")}");
114-
assetCandidate.SetMetadata("RelatedAsset", Path.GetFullPath(Path.Combine(OutputPath, "wwwroot", "_framework", Path.GetFileName(assetCandidate.GetMetadata("ResolvedFrom")))));
114+
115+
var resolvedFrom = assetCandidate.GetMetadata("ResolvedFrom");
116+
if (resolvedFrom == "{RawFileName}") // Satellite assembly found from `<Reference />` element
117+
resolvedFrom = candidate.GetMetadata("OriginalItemSpec");
118+
119+
assetCandidate.SetMetadata("RelatedAsset", Path.GetFullPath(Path.Combine(OutputPath, "wwwroot", "_framework", Path.GetFileName(resolvedFrom))));
115120

116121
assetCandidates.Add(assetCandidate);
117122
continue;

0 commit comments

Comments
 (0)