Rename NDirect -> PInvoke (#118228)

* Rename NDirect -> PInvoke

* Rename N/Direct -> PInvoke

* NDIRECTSTUB -> PINVOKESTUB

* Manual touch up

Co-authored-by: Copilot <[email protected]>

Author: jkotas

docs/design/coreclr/botr/guide-for-porting.md

@@ -340,7 +340,7 @@ Here is an annotated list of the stubs implemented for Unix on Arm64.
         calls. Necessary for all applications as this is how the main method is
         called.
 
-    2.  `NDirectImportThunk` – Needed to support saving off a set of arguments to
+    2.  `PInvokeImportThunk` – Needed to support saving off a set of arguments to
         a p/invoke so that the runtime can find the actual target. Also uses one
         of the secret arguments (Used by all p/invoke methods)
 

docs/design/coreclr/botr/method-descriptor.md

@@ -44,7 +44,7 @@ Used for less common IL methods that have generic instantiation or that do not h
 
 Internal methods implemented in unmanaged code. These are [methods marked with MethodImplAttribute(MethodImplOptions.InternalCall) attribute](corelib.md), delegate constructors and tlbimp constructors.
 
-**NDirect**
+**PInvoke**
 
 P/Invoke methods. These are methods marked with DllImport attribute.
 
@@ -270,14 +270,14 @@ ThisPtrRetBufPrecode looks like this:
 	jmp entrypoint
 	dw pMethodDesc
 
-**NDirectImportPrecode**
+**PInvokeImportPrecode**
 
-NDirectImportPrecode is used for lazy binding of unmanaged P/Invoke targets. This precode is for convenience and to reduce amount of platform specific plumbing.
+PInvokeImportPrecode is used for lazy binding of unmanaged P/Invoke targets. This precode is for convenience and to reduce amount of platform specific plumbing.
 
-Each NDirectMethodDesc has NDirectImportPrecode in addition to the regular precode.
+Each PInvokeMethodDesc has PInvokeImportPrecode in addition to the regular precode.
 
-NDirectImportPrecode looks like this on x86:
+PInvokeImportPrecode looks like this on x86:
 
 	mov eax,pMethodDesc
 	mov eax,eax // dummy instruction that marks the type of the precode
-	jmp NDirectImportThunk // loads P/Invoke target for pMethodDesc lazily
+	jmp PInvokeImportThunk // loads P/Invoke target for pMethodDesc lazily

docs/design/coreclr/botr/profiling.md

@@ -477,7 +477,7 @@ A profiler DLL is an unmanaged DLL that is effectively running as part of the CL
 Combining Managed and Unmanaged Code in a Code Profiler
 =======================================================
 
-A close review of the CLR Profiling API creates the impression that you could write a profiler that has managed and unmanaged components that call to each other through COM Interop or ndirect calls.
+A close review of the CLR Profiling API creates the impression that you could write a profiler that has managed and unmanaged components that call to each other through COM Interop or PInvoke calls.
 
 Although this is possible from a design perspective, the CLR Profiling API does not support it. A CLR profiler is supposed to be purely unmanaged. Attempts to combine managed and unmanaged code from a CLR profiler can cause crashes, hangs and deadlocks. The danger is clear since the managed parts of the profiler will "fire" events back to its unmanaged component, which subsequently would call into the managed part of the profiler etc. The danger at this point is clear.
 

docs/design/datacontracts/PrecodeStubs.md

@@ -194,7 +194,7 @@ After the initial precode type is determined, for stub precodes a refined precod
     internal enum KnownPrecodeType
     {
         Stub = 1,
-        PInvokeImport, // also known as NDirectImport in the runtime
+        PInvokeImport,
         Fixup,
         ThisPtrRetBuf,
         UMEntry,

docs/design/datacontracts/RuntimeTypeSystem.md

@@ -1083,7 +1083,7 @@ Checking if a method has a native code slot and getting its address
     {
         MethodClassification.IL => /*size of MethodDesc*/,
         MethodClassification.FCall => /* size of FCallMethodDesc */
-        MethodClassification.PInvoke => /* size of NDirectMethodDesc */
+        MethodClassification.PInvoke => /* size of PInvokeMethodDesc */
         MethodClassification.EEImpl => /* size of EEImplMethodDesc */
         MethodClassification.Array => /* size of ArrayMethodDesc */
         MethodClassification.Instantiated => /* size of InstantiatedMethodDesc */

src/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs

@@ -944,7 +944,7 @@ private unsafe IntPtr ConvertArrayToNative(object pManagedHome, int dwFlags)
                     }
 
                 default:
-                    throw new ArgumentException(SR.Arg_NDirectBadObject);
+                    throw new ArgumentException(SR.Arg_PInvokeBadObject);
             }
 
             // marshal the object as C-style array (UnmanagedType.LPArray)
@@ -1151,7 +1151,7 @@ internal IntPtr ConvertToNative(object pManagedHome, int dwFlags)
                 else
                 {
                     // this type is not supported for AsAny marshaling
-                    throw new ArgumentException(SR.Arg_NDirectBadObject);
+                    throw new ArgumentException(SR.Arg_PInvokeBadObject);
                 }
             }
 

src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp

@@ -474,7 +474,7 @@ ULONG32 DacDbiInterfaceImpl::GetCountOfInternalFrames(VMPTR_Thread vmThread)
         {
             // Skip new exception handling helpers
             InlinedCallFrame *pInlinedCallFrame = dac_cast<PTR_InlinedCallFrame>(pFrame);
-            PTR_NDirectMethodDesc pMD = pInlinedCallFrame->m_Datum;
+            PTR_PInvokeMethodDesc pMD = pInlinedCallFrame->m_Datum;
             TADDR datum = dac_cast<TADDR>(pMD);
             if ((datum & (TADDR)InlinedCallFrameMarker::Mask) == (TADDR)InlinedCallFrameMarker::ExceptionHandlingHelper)
             {
@@ -527,7 +527,7 @@ void DacDbiInterfaceImpl::EnumerateInternalFrames(VMPTR_Thread
         {
             // Skip new exception handling helpers
             InlinedCallFrame *pInlinedCallFrame = dac_cast<PTR_InlinedCallFrame>(pFrame);
-            PTR_NDirectMethodDesc pMD = pInlinedCallFrame->m_Datum;
+            PTR_PInvokeMethodDesc pMD = pInlinedCallFrame->m_Datum;
             TADDR datum = dac_cast<TADDR>(pMD);
             if ((datum & (TADDR)InlinedCallFrameMarker::Mask) == (TADDR)InlinedCallFrameMarker::ExceptionHandlingHelper)
             {

src/coreclr/debug/di/shimstackwalk.cpp

@@ -1202,7 +1202,7 @@ BOOL ShimStackWalk::CheckInternalFrame(ICorDebugFrame *     pNextStackFrame,
     // Special handling for the case where a managed method contains a M2U internal frame.
     // Normally only IL stubs contain M2U internal frames, but we may have inlined pinvoke calls in
     // optimized code.  In that case, we would have an InlinedCallFrame in a normal managed method on x86.
-    // On WIN64, we would have a normal NDirectMethodFrame* in a normal managed method.
+    // On WIN64, we would have a normal PInvokeMethodFrame* in a normal managed method.
     if (pStackWalkInfo->m_internalFrameType == STUBFRAME_M2U)
     {
         // create a temporary ICDStackWalk

src/coreclr/debug/ee/controller.cpp

@@ -5921,7 +5921,7 @@ bool DebuggerStepper::TrapStep(ControllerStackInfo *info, bool in)
 #endif
 
     // Note: we used to pass in the IP from the active frame to GetJitInfo, but there seems to be no value in that, and
-    // it was causing problems creating a stepper while sitting in ndirect stubs after we'd returned from the unmanaged
+    // it was causing problems creating a stepper while sitting in PInvoke stubs after we'd returned from the unmanaged
     // function that had been called.
     DebuggerJitInfo *ji = info->m_activeFrame.GetJitInfoFromFrame();
     if( ji != NULL )
@@ -6537,7 +6537,7 @@ void DebuggerStepper::TrapStepOut(ControllerStackInfo *info, bool fForceTraditio
                 _ASSERTE(dji != NULL);
 
                 // Note: we used to pass in the IP from the active frame to GetJitInfo, but there seems to be no value
-                // in that, and it was causing problems creating a stepper while sitting in ndirect stubs after we'd
+                // in that, and it was causing problems creating a stepper while sitting in PInvoke stubs after we'd
                 // returned from the unmanaged function that had been called.
                 ULONG reloffset = info->m_activeFrame.relOffset;
 
@@ -6816,7 +6816,7 @@ bool DebuggerStepper::SetRangesFromIL(DebuggerJitInfo *dji, COR_DEBUG_STEP_RANGE
     CONTRACTL_END;
 
     // Note: we used to pass in the IP from the active frame to GetJitInfo, but there seems to be no value in that, and
-    // it was causing problems creating a stepper while sitting in ndirect stubs after we'd returned from the unmanaged
+    // it was causing problems creating a stepper while sitting in PInvoke stubs after we'd returned from the unmanaged
     // function that had been called.
     MethodDesc *fd = dji->m_nativeCodeVersion.GetMethodDesc();
 

src/coreclr/debug/ee/frameinfo.cpp

@@ -1503,7 +1503,7 @@ StackWalkAction DebuggerWalkStackProc(CrawlFrame *pCF, void *data)
               (pPrevFrame->GetFrameType() == Frame::TYPE_EXIT) &&
               !HasExitRuntime(pPrevFrame, d, NULL) )
     {
-        // This is for the inlined NDirectMethodFrameGeneric case.  We have not exit the runtime yet, so the current
+        // This is for the inlined PInvokeMethodFrameGeneric case.  We have not exit the runtime yet, so the current
         // frame should still be regarded as the leaf frame.
         d->info.fIsLeaf = true;
     }