Fix potential overflow (#120357)

geor-gen · EgorBo · web-flow · commit fe17548c88dc · 2025-10-14T08:36:41.000-07:00
* Fix potential overflow

* Fixed misspelling

* Length check change

* Update src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs

Co-authored-by: Egor Bogatov &lt;egorbo@gmail.com&gt;

---------

Co-authored-by: Egor Bogatov &lt;egorbo@gmail.com&gt;
diff --git a/src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs b/src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs
@@ -333,7 +333,7 @@ private static ReadOnlySpan<byte> GetField(MessageField field, ReadOnlySpan<byte
 
             private static unsafe void SetField(ref MessageField field, int length, int offset)
             {
-                if (length > short.MaxValue)
+                if (length is < 0 or > short.MaxValue)
                 {
                     throw new Win32Exception(NTE_FAIL);
                 }

Original file line number	Diff line number	Diff line change
`@@ -333,7 +333,7 @@ private static ReadOnlySpan<byte> GetField(MessageField field, ReadOnlySpan<byte`
`333`	`333`
`334`	`334`	`private static unsafe void SetField(ref MessageField field, int length, int offset)`
`335`	`335`	`{`
`336`		`- if (length > short.MaxValue)`
	`336`	`+ if (length is < 0 or > short.MaxValue)`
`337`	`337`	`{`
`338`	`338`	`throw new Win32Exception(NTE_FAIL);`
`339`	`339`	`}`