DateTime's short time formatting

[divinebovine]

I came across this issue when I was writing unit tests for some string values that use DateTime's short time format.

The string that it generates seems to use 0x2F 0x20 for the spacing instead of 0x20 0x00, which is what I'm expecting.

This just seems wrong to me, but if it's desired behavior, can someone explain it?

[huoyaoyuan]

#108742 #102220 #103750 #107842 and so on.

You shouldn't be expecting an invariant formatted string. It does change by OS type and version.

[Clockwork-Muse]

Any tests that checks the output of any function referencing culture information (usually formatting) are inherently brittle and prone to breakage. Some of our timezone tests fail relatively often on Android because of this.

For tests, pick one:

• Test that you get some output, but don't validate the output. Generally you shouldn't be inspecting or relying on the output in your actual application code, and instead just display it to the user.
• Construct a psuedo locale/CultureInfo and set up all the properties. This ensures constant data, and can be useful to help surface places that you're not flowing the locale through your code.