Why is the HttpClient constructor not internal?

[CraigComeOnThisNameCantBeTaken]

I often see it used as a concrete instantiation with a using statement, but this doesn't manage sockets and leads to stale DNS lookups and socket exhaustion.

What is the reason for allowing this usage please? If it were internal developers could not make that mistake.

[huoyaoyuan]

but this doesn't manage sockets and leads to stale DNS lookups and socket exhaustion.

Socket is managed by connection pool which is used by HttpClientHandler. Each HttpClient has its own connection pool.

Although it's typically shared during application lifetime, short-lived ones are also necessary for application which only uses network very rarely.

[CraigComeOnThisNameCantBeTaken]

Thanks

[CraigComeOnThisNameCantBeTaken]

Am I correct that the HttpClientHandler doesnt release sockets when HttpClient is disposed?

[huoyaoyuan]

HttpClient.Dispose calls HttpClientHandler.Dispose, which finally calls HttpConnectionHandler.Dispose, which calls HttpCollectionPoolManager.Dispose, which disposes each HttpConnectionPool, which disposes HttpConnection, which disposes sockets eventually.

The sockets are wrapped into NetworkStream, so you need to search for Stream.Dispose in System.Net.Http project. The disposal for non-exceptional path should be here:

runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnection.cs

Line 133 in 8c553ad

_stream.Dispose();