Why does ILogger.BeginScope<TState>(TState) return IDisposable?

[paulomorgado]

In what situations would ILogger.BeginScope<TState>(TState) return a null IDisposable?

[huoyaoyuan]

There are implementations that returns null. If you search at source.dot.net, you can find that Microsoft.AspNetCore.Grpc.JsonTranscoding.IntegrationTests.Infrastructure.ForwardingLogger returns null.

[paulomorgado]

That is dangerous.

It should return, at least, something like:

private sealed class EmptyDisposable : IDisposable
{
    public static EmptyDisposable Instance { get; } = new EmptyDisposable();

    private EmptyDisposable()
    {
    }

    void IDisposable.Dispose()
    {
        // Interface implementation
    }
}

[colejohnson66]

Why is it dangerous? You should never be manually calling Dispose if you don’t need to. A using block will handle nulls for you.

[paulomorgado]

In hindsight, I might have overthought this.