Test inlining changes for CredentialCache perf#124614
Draft
MihaZupan wants to merge 1 commit intodotnet:mainfrom
Draft
Test inlining changes for CredentialCache perf#124614MihaZupan wants to merge 1 commit intodotnet:mainfrom
MihaZupan wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-meta |
Member
Author
|
@EgorBot -profiler -linux_azure_arm using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
using System;
using System.Net;
public class CredentialCacheTests
{
private const string UriPrefix = "http://name";
private const string AuthenticationType = "authType";
private static readonly NetworkCredential s_credential = new();
private static readonly CredentialCache _cache = CreateCredentialCache(10);
private readonly string _uriString = "http://name5";
private Uri? _reusedUri;
[Benchmark]
public NetworkCredential GetCredential_Uri() => _cache.GetCredential(new Uri(_uriString), AuthenticationType);
private static CredentialCache CreateCredentialCache(int uriCount)
{
var cc = new CredentialCache();
for (int i = 0; i < uriCount; i++)
{
Uri uri = new Uri(UriPrefix + i.ToString());
cc.Add(uri, AuthenticationType, s_credential);
}
return cc;
}
} |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a [MethodImpl(MethodImplOptions.NoInlining)] attribute to the IsPrefix method in CredentialCacheKey to investigate potential performance improvements for the GetCredential_Uri benchmark, which showed a 35% regression (309ns → 418ns) according to issue #124520. The change prevents the JIT compiler from inlining this method into its caller.
Changes:
- Added
NoInliningattribute to theIsPrefixmethod to test if preventing inlining resolves the performance regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#124520