[browser] Generate javascript bundler friendly Blazor JS initializers #116849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Blazor boot JSON generation to produce bundler-friendly JS initializers.
- Swaps
libraryInitializersfrom a dictionary to aList<JsAsset>in the JSON model - Updates the builder helper to map
libraryInitializersusingMapJsAssetswith a subfolder path
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| BootJsonData.cs | Changed type of libraryInitializers from ResourceHashesByNameDictionary to List<JsAsset> |
| BootJsonBuilderHelper.cs | Updated assignment of libraryInitializers to use MapJsAssets for bundler compatibility |
Comments suppressed due to low confidence (2)
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonBuilderHelper.cs:259
- There are no existing unit tests that cover the new bundler-friendly mapping of
libraryInitializers. Add or update tests to verify that JS assets are correctly generated and serialized in different scenarios.
assets.libraryInitializers = MapJsAssets(resources.libraryInitializers, subFolder: "..");
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonBuilderHelper.cs:259
- Changing
libraryInitializersfrom a dictionary to a list alters lookup complexity from O(1) to O(n). Verify that consumers of the generated JSON do not rely on dictionary-style key lookups or consider retaining an in-memory dictionary for efficient access.
assets.libraryInitializers = MapJsAssets(resources.libraryInitializers, subFolder: "..");
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonData.cs
Outdated
Show resolved
Hide resolved
javiercn
approved these changes
Jun 20, 2025
|
/backport to release/10.0-preview6 |
|
Started backporting to release/10.0-preview6: https://github.com/dotnet/runtime/actions/runs/15781004801 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart to dotnet/aspnetcore#62417.
Generate Blazor JS initializers in way that is compatible with javascript bundlers.