RefreshNow is not needed when OnActivateAsync is not overridden

egil · egil · commit 90ba44e4162f · 2025-03-17T14:48:02.000Z
diff --git a/orleans/JournaledTodoList/JournaledTodoList.WebApp/Grains/TodoListGrain.cs b/orleans/JournaledTodoList/JournaledTodoList.WebApp/Grains/TodoListGrain.cs
@@ -35,9 +35,6 @@ public async Task<ImmutableArray<TodoListEvent>> GetHistoryAsync()
 
     public async Task<TodoList> GetTodoListAsync()
     {
-        // Ensure we are State object is up to date before returning.
-        await RefreshNow();
-
         var list = new TodoList(
             Name: this.GetPrimaryKeyString(),
             Items: State.Items.Values.OrderBy(x => x.Id).ToImmutableArray(),

Original file line number	Diff line number	Diff line change
`@@ -35,9 +35,6 @@ public async Task<ImmutableArray<TodoListEvent>> GetHistoryAsync()`
`35`	`35`
`36`	`36`	`public async Task<TodoList> GetTodoListAsync()`
`37`	`37`	`{`
`38`		`- // Ensure we are State object is up to date before returning.`
`39`		`- await RefreshNow();`
`40`		`-`
`41`	`38`	`var list = new TodoList(`
`42`	`39`	`Name: this.GetPrimaryKeyString(),`
`43`	`40`	`Items: State.Items.Values.OrderBy(x => x.Id).ToImmutableArray(),`