Reorder disposing of the CryptoStream and HashAlgorithm to avoid ODE (#252)

eerhardt · web-flow · commit 472837a45e8c · 2022-11-15T07:28:01.000-06:00
Fix #246
diff --git a/Microsoft.NET.Build.Containers/Layer.cs b/Microsoft.NET.Build.Containers/Layer.cs
@@ -139,8 +139,10 @@ protected override void Dispose(bool disposing)
         {
             try
             {
-                hashAlgorithm.Dispose();
+                // dispose hashAlgorithm after sha256Stream since sha256Stream references/uses it
                 sha256Stream.Dispose();
+                hashAlgorithm.Dispose();
+
                 compressionStream.Dispose();
             }
             finally

Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,10 @@ protected override void Dispose(bool disposing)`
`139`	`139`	`{`
`140`	`140`	`try`
`141`	`141`	`{`
`142`		`- hashAlgorithm.Dispose();`
	`142`	`+ // dispose hashAlgorithm after sha256Stream since sha256Stream references/uses it`
`143`	`143`	`sha256Stream.Dispose();`
	`144`	`+ hashAlgorithm.Dispose();`
	`145`	`+`
`144`	`146`	`compressionStream.Dispose();`
`145`	`147`	`}`
`146`	`148`	`finally`