Merge pull request #234 from rainersigwald/shared-httpclient

Long-lived HttpClient

Author: rainersigwald

Microsoft.NET.Build.Containers/Registry.cs

@@ -21,7 +21,7 @@ public record struct Registry(Uri BaseUri)
 
     public async Task<Image> GetImageManifest(string name, string reference)
     {
-        using HttpClient client = GetClient();
+        HttpClient client = GetClient();
 
         var response = await client.GetAsync(new Uri(BaseUri, $"/v2/{name}/manifests/{reference}"));
 
@@ -72,7 +72,7 @@ public async Task<string> DownloadBlob(string name, Descriptor descriptor)
 
         // No local copy, so download one
 
-        using HttpClient client = GetClient();
+        HttpClient client = GetClient();
 
         var response = await client.GetAsync(new Uri(BaseUri, $"/v2/{name}/blobs/{descriptor.Digest}"), HttpCompletionOption.ResponseHeadersRead);
 
@@ -103,7 +103,7 @@ public async Task Push(Layer layer, string name, Action<string> logProgressMessa
 
     private readonly async Task UploadBlob(string name, string digest, Stream contents)
     {
-        using HttpClient client = GetClient();
+        HttpClient client = GetClient();
 
         if (await BlobAlreadyUploaded(name, digest, client))
         {
@@ -157,9 +157,16 @@ private readonly async Task<bool> BlobAlreadyUploaded(string name, string digest
         return false;
     }
 
+    private static HttpClient _client = CreateClient();
+
     private static HttpClient GetClient()
     {
-        var clientHandler = new AuthHandshakeMessageHandler(new HttpClientHandler() { UseDefaultCredentials = true });
+        return _client;
+    }
+
+    private static HttpClient CreateClient()
+    {
+        var clientHandler = new AuthHandshakeMessageHandler(new SocketsHttpHandler() { PooledConnectionLifetime = TimeSpan.FromMilliseconds(10 /* total guess */) });
         HttpClient client = new(clientHandler);
 
         client.DefaultRequestHeaders.Accept.Clear();
@@ -179,7 +186,7 @@ public async Task Push(Image x, string name, string? tag, string baseName, Actio
     {
         tag ??= "latest";
 
-        using HttpClient client = GetClient();
+        HttpClient client = GetClient();
         var reg = this;
         await Task.WhenAll(x.LayerDescriptors.Select(async descriptor => {
             string digest = descriptor.Digest;