use real MSBuild for all test evaluations

Author: baronfel

Microsoft.NET.Build.Containers/ParseContainerProperties.cs

@@ -115,20 +115,15 @@ public override bool Execute()
             else
             {
                 validTags = Array.Empty<string>();
-                Log.LogError(null, KnownStrings.ErrorCodes.CONTAINER004, "Container.InvalidTag", null, 0, 0, 0, 0, $"Invalid {nameof(ContainerImageTag)} provided: {{0}}. Image tags must be alphanumeric, underscore, hyphen, or period.", ContainerImageTag);
+                Log.LogError(null, KnownStrings.ErrorCodes.CONTAINER004, "Container.InvalidTag", null, 0, 0, 0, 0, "Invalid {0} provided: {1}. Image tags must be alphanumeric, underscore, hyphen, or period.", nameof(ContainerImageTag), ContainerImageTag);
             }
         }
         else if (ContainerImageTags.Length != 0 && TryValidateTags(ContainerImageTags, out var valids, out var invalids))
         {
             validTags = valids;
             if (invalids.Any())
             {
-                (string message, string args) = invalids switch
-                {
-                    { Length: 1 } => ($"Invalid {nameof(ContainerImageTags)} provided: {{0}}. {nameof(ContainerImageTags)} must be a semicolon-delimited list of valid image tags. Image tags must be alphanumeric, underscore, hyphen, or period.", invalids[0]),
-                    _ => ($"Invalid {nameof(ContainerImageTags)} provided: {{0}}. {nameof(ContainerImageTags)} must be a semicolon-delimited list of valid image tags. Image tags must be alphanumeric, underscore, hyphen, or period.", String.Join(", ", invalids))
-                };
-                Log.LogError(null, KnownStrings.ErrorCodes.CONTAINER004, "Container.InvalidTag", null, 0, 0, 0, 0, message, args);
+                Log.LogError(null, KnownStrings.ErrorCodes.CONTAINER004, "Container.InvalidTag", null, 0, 0, 0, 0, "Invalid {0} provided: {1}. {0} must be a semicolon-delimited list of valid image tags. Image tags must be alphanumeric, underscore, hyphen, or period.", nameof(ContainerImageTags), String.Join(",", invalids));
                 return !Log.HasLoggedErrors;
             }
         }

Test.Microsoft.NET.Build.Containers.Filesystem/KnownStrings.cs

@@ -0,0 +1,28 @@
+namespace Test.Microsoft.NET.Build.Containers;
+
+public static class KnownStrings {
+    public static string ContainerBaseImage = nameof(ContainerBaseImage);
+    public static string ContainerRegistry = nameof(ContainerRegistry);
+    public static string ContainerImageName = nameof(ContainerImageName);
+    public static string ContainerImageTag = nameof(ContainerImageTag);
+    public static string ContainerImageTags = nameof(ContainerImageTags);
+    public static string ContainerWorkingDirectory = nameof(ContainerWorkingDirectory);
+    public static string ContainerEntrypoint = nameof(ContainerEntrypoint);
+    public static string UseAppHost = nameof(UseAppHost);
+    public static string ContainerLabel = nameof(ContainerLabel);
+    public static string SelfContained = nameof(SelfContained);
+    public static string ContainerPort = nameof(ContainerPort);
+    public static string ContainerEnvironmentVariable = nameof(ContainerEnvironmentVariable);
+
+    public static string ComputeContainerConfig = nameof(ComputeContainerConfig);
+    public static string AssemblyName = nameof(AssemblyName);
+    public static string ContainerBaseRegistry = nameof(ContainerBaseRegistry);
+    public static string ContainerBaseName = nameof(ContainerBaseName);
+    public static string ContainerBaseTag = nameof(ContainerBaseTag);
+
+    public static class ErrorCodes {
+        public static string CONTAINER001 = nameof(CONTAINER001);
+        public static string CONTAINER004 = nameof(CONTAINER004);
+        public static string CONTAINER005 = nameof(CONTAINER005);
+    }
+}