Fix bug in GlobalPrefixRemover preventing the removal of just global (it was also removing System)

carlossanlop · carlossanlop · commit 09d06de765fe · 2025-04-07T10:16:42.000-07:00
diff --git a/src/Compatibility/ApiDiff/Microsoft.DotNet.ApiDiff/SyntaxRewriter/GlobalPrefixRemover.cs b/src/Compatibility/ApiDiff/Microsoft.DotNet.ApiDiff/SyntaxRewriter/GlobalPrefixRemover.cs
@@ -18,7 +18,7 @@ internal class GlobalPrefixRemover : CSharpSyntaxRewriter
         if (node.Left is AliasQualifiedNameSyntax alias &&
             alias.Alias.Identifier.Text == GlobalPrefix)
         {
-            return node.Right;
+            node = SyntaxFactory.QualifiedName(alias.Name, node.Right).WithTriviaFrom(node);
         }
         return base.VisitQualifiedName(node);
     }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ internal class GlobalPrefixRemover : CSharpSyntaxRewriter`
`18`	`18`	`if (node.Left is AliasQualifiedNameSyntax alias &&`
`19`	`19`	`alias.Alias.Identifier.Text == GlobalPrefix)`
`20`	`20`	`{`
`21`		`- return node.Right;`
	`21`	`+ node = SyntaxFactory.QualifiedName(alias.Name, node.Right).WithTriviaFrom(node);`
`22`	`22`	`}`
`23`	`23`	`return base.VisitQualifiedName(node);`
`24`	`24`	`}`