Skip to content

Commit 0c1e1fc

Browse files
mmitcheViktorHofer
andauthored
Enable CollatePackageDownloads (#51072)
Co-authored-by: Viktor Hofer <[email protected]>
1 parent f199e46 commit 0c1e1fc

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/Layout/redist/targets/GeneratePackagePruneData.targets

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,12 @@
3030
</MSBuild>
3131
</Target>
3232

33-
<!-- TODO: Remove conditions from UsingTask and target when a new SDK with the CollatePackageDownload task built-in is consumed. -->
34-
<UsingTask TaskName="Microsoft.NET.Build.Tasks.CollatePackageDownloads" AssemblyFile="$(MicrosoftNETBuildTasksAssembly)" Condition="'$(MaxNetVersion)' != '$(TargetingPackPruneVersion)'" />
33+
<UsingTask TaskName="Microsoft.NET.Build.Tasks.CollatePackageDownloads" AssemblyFile="$(MicrosoftNETBuildTasksAssembly)" />
3534
<Target Name="AddTargetingPacksForPruneDataAsPackageDownloads"
3635
BeforeTargets="CollectPackageDownloads"
37-
DependsOnTargets="GetTargetingPacksForPruneData"
38-
Condition="'$(MaxNetVersion)' != '$(TargetingPackPruneVersion)'">
39-
<CollatePackageDownloads Packages="@(TargetingPackForPruneData->Metadata('PackageName'))">
36+
DependsOnTargets="GetTargetingPacksForPruneData">
37+
<CollatePackageDownloads Packages="@(TargetingPackForPruneData->Metadata('PackageName'))"
38+
Condition="'@(TargetingPackForPruneData)' != ''">
4039
<Output TaskParameter="PackageDownloads" ItemName="PackageDownload" />
4140
</CollatePackageDownloads>
4241
</Target>

src/Tasks/sdk-tasks/sdk-tasks.InTree.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
<UsingTask TaskName="AddMetadataIsPE" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
1414
<UsingTask TaskName="CalculateTemplateVersions" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
1515
<UsingTask TaskName="ChangeEntryPointLibraryName" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
16-
<UsingTask TaskName="CollatePackageDownloads" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
1716
<UsingTask TaskName="Crossgen" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
1817
<UsingTask TaskName="ExtractArchiveToDirectory" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />
1918
<UsingTask TaskName="GenerateDefaultRuntimeFrameworkVersion" AssemblyFile="$(SdkTasksAssembly)" TaskFactory="TaskHostFactory" />

0 commit comments

Comments
 (0)