Switch to Path.Combine since join is not supported on framework

marcpopMSFT · marcpopMSFT · commit 0cc58a2814ff · 2024-12-13T10:10:05.000-08:00
diff --git a/test/HelixTasks/SDKCustomCreateXUnitWorkItemsWithTestExclusion.cs b/test/HelixTasks/SDKCustomCreateXUnitWorkItemsWithTestExclusion.cs
@@ -149,7 +149,7 @@ private async Task<List<ITaskItem>> PrepareWorkItem(ITaskItem xunitProject)
             foreach (var assemblyPartitionInfo in assemblyPartitionInfos)
             {
                 string command;
-                string logFileLocation = Path.Join(Environment.GetEnvironmentVariable("HELIX_WORKITEM_UPLOAD_ROOT"),"dotnetTestLog.log");
+                string logFileLocation = Path.Combine(Environment.GetEnvironmentVariable("HELIX_WORKITEM_UPLOAD_ROOT"),"dotnetTestLog.log");
 
                 var testFilter = string.IsNullOrEmpty(assemblyPartitionInfo.ClassListArgumentString) ? "" : $"--filter \"{assemblyPartitionInfo.ClassListArgumentString}\"";
                 command = $"{driver} test {assemblyName} -e HELIX_WORK_ITEM_TIMEOUT={timeout} {testExecutionDirectory} {msbuildAdditionalSdkResolverFolder} " +

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ private async Task<List<ITaskItem>> PrepareWorkItem(ITaskItem xunitProject)`
`149`	`149`	`foreach (var assemblyPartitionInfo in assemblyPartitionInfos)`
`150`	`150`	`{`
`151`	`151`	`string command;`
`152`		`- string logFileLocation = Path.Join(Environment.GetEnvironmentVariable("HELIX_WORKITEM_UPLOAD_ROOT"),"dotnetTestLog.log");`
	`152`	`+ string logFileLocation = Path.Combine(Environment.GetEnvironmentVariable("HELIX_WORKITEM_UPLOAD_ROOT"),"dotnetTestLog.log");`
`153`	`153`
`154`	`154`	`var testFilter = string.IsNullOrEmpty(assemblyPartitionInfo.ClassListArgumentString) ? "" : $"--filter \"{assemblyPartitionInfo.ClassListArgumentString}\"";`
`155`	`155`	`command = $"{driver} test {assemblyName} -e HELIX_WORK_ITEM_TIMEOUT={timeout} {testExecutionDirectory} {msbuildAdditionalSdkResolverFolder} " +`