Skip to content

Commit 131977c

Browse files
committed
Update the sign check to remove the exclusions but only check on signed builds
1 parent 5a8a926 commit 131977c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/Installer/redist-installer/targets/BundledManifests.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
</ItemGroup>
5151

5252
<Target Name="ValidateBundledManifestSigning"
53-
Condition=" '$(OS)' == 'Windows_NT' and '$(Architecture)' != 'arm' ">
53+
Condition=" '$(OS)' == 'Windows_NT' and '$(Architecture)' != 'arm' and '$(Sign)' == 'true' ">
5454
<PropertyGroup>
5555
<SignCheckExe>$(PkgMicrosoft_DotNet_SignCheck)\tools\Microsoft.DotNet.SignCheck.exe</SignCheckExe>
5656
<SignCheckLog Condition="'$(SignCheckLog)' == ''">$(ArtifactsLogDir)\workloadmanifestsigncheck.log</SignCheckLog>
@@ -60,7 +60,7 @@
6060
<ItemGroup>
6161
<!-- Don't try to validate signing for workload manifests that will be signed as part of post-build signing -->
6262
<BundledManifestsToValidateSigning Include="@(BundledManifests)"
63-
Exclude="Microsoft.NET.Workload.Mono.ToolChain.Current;Microsoft.NET.Workload.Mono.ToolChain.net6;Microsoft.NET.Workload.Mono.ToolChain.net7;Microsoft.NET.Workload.Mono.ToolChain.net8;Microsoft.NET.Workload.Emscripten.Current;Microsoft.NET.Workload.Emscripten.net6;Microsoft.NET.Workload.Emscripten.net7;Microsoft.NET.Workload.Emscripten.net8;Microsoft.NET.Sdk.Aspire">
63+
Exclude="Microsoft.NET.Sdk.Aspire">
6464
<RestoredMsiPathInNupkg>$([MSBuild]::NormalizePath($([System.IO.Directory]::GetFiles('%(RestoredMsiNupkgContentPath)/data/', '*$(MsiArchitectureForWorkloadManifests).msi'))))</RestoredMsiPathInNupkg>
6565
</BundledManifestsToValidateSigning>
6666

0 commit comments

Comments
 (0)