Skip to content

Commit 1adb812

Browse files
committed
Disable flakey container registry tests
These tests have a high number of failures documented at (Skip = "#49502"). The registry issue may not be solved until funding is increased or engineering effort is made to handle this case better and not run the tests. Merge
1 parent 16127c3 commit 1adb812

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

test/Microsoft.NET.Build.Containers.IntegrationTests/DockerRegistryTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public DockerRegistryTests(ITestOutputHelper testOutput)
1717
_loggerFactory = new TestLoggerFactory(testOutput);
1818
}
1919

20-
[DockerAvailableFact]
20+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
2121
public async Task GetFromRegistry()
2222
{
2323
var loggerFactory = new TestLoggerFactory(_testOutput);

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void Dispose()
4242
_loggerFactory.Dispose();
4343
}
4444

45-
[DockerAvailableFact()]
45+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
4646
public async Task ApiEndToEndWithRegistryPushAndPull()
4747
{
4848
ILogger logger = _loggerFactory.CreateLogger(nameof(ApiEndToEndWithRegistryPushAndPull));
@@ -89,7 +89,7 @@ public async Task ApiEndToEndWithRegistryPushAndPull()
8989
}
9090
}
9191

92-
[DockerAvailableFact()]
92+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
9393
public async Task ApiEndToEndWithLocalLoad()
9494
{
9595
ILogger logger = _loggerFactory.CreateLogger(nameof(ApiEndToEndWithLocalLoad));
@@ -130,7 +130,7 @@ public async Task ApiEndToEndWithLocalLoad()
130130
}
131131
}
132132

133-
[DockerAvailableFact()]
133+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
134134
public async Task ApiEndToEndWithArchiveWritingAndLoad()
135135
{
136136
ILogger logger = _loggerFactory.CreateLogger(nameof(ApiEndToEndWithArchiveWritingAndLoad));
@@ -180,7 +180,7 @@ public async Task ApiEndToEndWithArchiveWritingAndLoad()
180180
}
181181
}
182182

183-
[DockerAvailableFact]
183+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
184184
public async Task TarballsHaveCorrectStructure()
185185
{
186186
var archiveFile = Path.Combine(TestSettings.TestArtifactsDirectory,
@@ -351,7 +351,7 @@ private string BuildLocalApp([CallerMemberName] string testName = "TestName", st
351351
return publishDirectory;
352352
}
353353

354-
[DockerAvailableFact()]
354+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
355355
public async Task EndToEnd_MultiProjectSolution()
356356
{
357357
ILogger logger = _loggerFactory.CreateLogger(nameof(EndToEnd_MultiProjectSolution));
@@ -441,7 +441,7 @@ public async Task EndToEnd_MultiProjectSolution()
441441
/// It's safe to load the target for libraries in a multi-targeted context because libraries don't have EnableSdkContainerSupport
442442
/// enabled by default, so the target will be skipped.
443443
/// </summary>
444-
[DockerAvailableFact]
444+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
445445
public async Task EndToEnd_MultiProjectSolution_with_multitargeted_library()
446446
{
447447
ILogger logger = _loggerFactory.CreateLogger(nameof(EndToEnd_MultiProjectSolution_with_multitargeted_library));
@@ -509,7 +509,7 @@ public async Task EndToEnd_MultiProjectSolution_with_multitargeted_library()
509509
commandResult.Should().HaveStdOutContaining("Pushed image 'webapp:latest'");
510510
}
511511

512-
[DockerAvailableTheory()]
512+
[DockerAvailableTheory(Skip = "https://github.com/dotnet/sdk/issues/49502")]
513513
[InlineData("webapi", false)]
514514
[InlineData("webapi", true)]
515515
[InlineData("worker", false)]
@@ -685,7 +685,7 @@ public async Task EndToEnd_NoAPI_ProjectType(string projectType, bool addPackage
685685
privateNuGetAssets.Delete(true);
686686
}
687687

688-
[DockerAvailableTheory()]
688+
[DockerAvailableTheory(Skip = "https://github.com/dotnet/sdk/issues/49502")]
689689
[InlineData(DockerRegistryManager.FullyQualifiedBaseImageAspNet)]
690690
[InlineData(DockerRegistryManager.FullyQualifiedBaseImageAspNetDigest)]
691691
public void EndToEnd_NoAPI_Console(string baseImage)
@@ -768,7 +768,7 @@ public void EndToEnd_NoAPI_Console(string baseImage)
768768
privateNuGetAssets.Delete(true);
769769
}
770770

771-
[DockerAvailableFact]
771+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
772772
public void EndToEnd_SingleArch_NoRid()
773773
{
774774
// Create a new console project
@@ -860,7 +860,7 @@ public void EndToEndMultiArch_LocalRegistry(string imageName)
860860
newProjectDir.Delete(true);
861861
}
862862

863-
[DockerAvailableFact]
863+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
864864
public void MultiArchStillAllowsSingleRID()
865865
{
866866
string imageName = NewImageName();
@@ -912,7 +912,7 @@ public void MultiArchStillAllowsSingleRID()
912912
newProjectDir.Delete(true);
913913
}
914914

915-
[DockerAvailableFact]
915+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
916916
public void MultiArchStillAllowsSingleRIDUsingJustRIDProperties()
917917
{
918918
string imageName = NewImageName();
@@ -1432,7 +1432,7 @@ static string[] DecideEntrypoint(string rid, string appName, string workingDir)
14321432
}
14331433
}
14341434

1435-
[DockerAvailableFact]
1435+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
14361436
public async void CheckDownloadErrorMessageWhenSourceRepositoryThrows()
14371437
{
14381438
var loggerFactory = new TestLoggerFactory(_testOutput);

0 commit comments

Comments
 (0)