Simplify code and translations

Author: edvilme

src/Cli/dotnet/Commands/CliCommandStrings.resx

@@ -2479,4 +2479,7 @@ To display a value, specify the corresponding command-line option without provid
   <data name="ToolRunFromSourceOptionDescription" xml:space="preserve">
     <value>Executes a tool from source without permanently installing it. </value>
   </data>
-</root>
+  <data name="ToolRunFromSourceUserConfirmationPrompt" xml:space="preserve">
+    <value>Tool not found in the system. Do you want to run it from source? [y/n] </value>
+  </data>
+</root>

src/Cli/dotnet/Commands/Tool/Run/ToolRunCommandParser.cs

@@ -40,7 +40,7 @@ internal static class ToolRunCommandParser
 
     public static readonly Option<string[]> FromSourceAddSourceOption = ToolInstallCommandParser.AddSourceOption;
 
-    public static readonly Option<VerbosityOptions> VerbosityOption = CommonOptions.VerbosityOption;
+    public static readonly Option<VerbosityOptions> FromSourceVerbosityOption = CommonOptions.VerbosityOption;
 
     private static readonly Command Command = ConstructCommand();
 
@@ -56,11 +56,12 @@ private static Command ConstructCommand()
         command.Arguments.Add(CommandNameArgument);
         command.Arguments.Add(CommandArgument);
         command.Options.Add(RollForwardOption);
+
         command.Options.Add(FromSourceOption);
         command.Options.Add(FromSourceConfigFile);
         command.Options.Add(FromSourceSourceOption);
         command.Options.Add(FromSourceAddSourceOption);
-        command.Options.Add(VerbosityOption);
+        command.Options.Add(FromSourceVerbosityOption);
 
         command.Options.Add(ToolCommandRestorePassThroughOptions.IgnoreFailedSourcesOption);
         command.Options.Add(ToolCommandRestorePassThroughOptions.InteractiveRestoreOption);

src/Cli/dotnet/Commands/Tool/Run/ToolRunFromSourceCommand.cs

@@ -5,19 +5,12 @@
 using Microsoft.DotNet.Cli.CommandFactory;
 using Microsoft.DotNet.Cli.CommandFactory.CommandResolution;
 using Microsoft.DotNet.Cli.Commands.Tool.Install;
-using Microsoft.DotNet.Cli.ToolManifest;
 using Microsoft.DotNet.Cli.ToolPackage;
-using Microsoft.DotNet.Cli.Utils;
-using Microsoft.DotNet.Cli.Utils.Extensions;
-using Microsoft.Extensions.EnvironmentAbstractions;
-using NuGet.Frameworks;
-using NuGet.Packaging;
 using NuGet.Versioning;
 
 namespace Microsoft.DotNet.Cli.Commands.Tool.Run
 {
-    internal class ToolRunFromSourceCommand(
-        ParseResult result) : CommandBase(result)
+    internal class ToolRunFromSourceCommand(ParseResult result) : CommandBase(result)
     {
         private readonly string? _toolCommandName = result.GetValue(ToolRunCommandParser.CommandNameArgument);
         private readonly IEnumerable<string>? _forwardArguments = result.GetValue(ToolRunCommandParser.CommandArgument);
@@ -27,11 +20,11 @@ internal class ToolRunFromSourceCommand(
         private readonly string[] _addSource = result.GetValue(ToolRunCommandParser.FromSourceAddSourceOption) ?? [];
         private readonly bool _ignoreFailedSources = result.GetValue(ToolCommandRestorePassThroughOptions.IgnoreFailedSourcesOption);
         private readonly bool _interactive = result.GetValue(ToolCommandRestorePassThroughOptions.InteractiveRestoreOption);
-        private readonly VerbosityOptions _verbosity = result.GetValue(ToolRunCommandParser.VerbosityOption);
+        private readonly VerbosityOptions _verbosity = result.GetValue(ToolRunCommandParser.FromSourceVerbosityOption);
 
         public override int Execute()
         {
-            if (!UserAgreedToExecuteFromSource())
+            if (!UserAgreedToRunFromSource())
             {
                 return 1;
             }
@@ -46,17 +39,12 @@ public override int Execute()
 
             string tempDirectory = PathUtilities.CreateTempSubdirectory();
 
-            ToolManifestFinder toolManifestFinder = new ToolManifestFinder(new(tempDirectory));
-            ToolManifestEditor toolManifestEditor = new ToolManifestEditor();
-            FilePath toolManifestPath = toolManifestFinder.FindFirst(true);
-
             ToolPackageStoreAndQuery toolPackageStoreAndQuery = new(new(tempDirectory));
             ToolPackageDownloader toolPackageDownloader = new(toolPackageStoreAndQuery);
 
             IToolPackage toolPackage = toolPackageDownloader.InstallPackage(
                 new PackageLocation(
-                    nugetConfig: _configFile != null ? new FilePath(_configFile) : null,
-                    rootConfigDirectory: toolManifestPath.GetDirectoryPath().GetParentPath(),
+                    nugetConfig: _configFile != null ? new(_configFile) : null,
                     sourceFeedOverrides: _sources,
                     additionalFeeds: _addSource),
                 packageId: packageId,
@@ -73,10 +61,10 @@ public override int Execute()
             return result.ExitCode;
         }
 
-        private bool UserAgreedToExecuteFromSource()
+        private bool UserAgreedToRunFromSource()
         {
             // TODO: Use a better way to ask for user input
-            Console.Write("Tool will be run from source. Accept? [y]".Red());
+            Console.Write(CliCommandStrings.ToolRunFromSourceUserConfirmationPrompt);
             bool userAccepted = Console.ReadKey().Key == ConsoleKey.Y;
             Console.WriteLine();
             return userAccepted;