Fix package prune data for .NET Core 2.x

Author: dsplaisted

src/Microsoft.CodeAnalysis.NetAnalyzers/src/RulesMissingDocumentation.md

@@ -2,7 +2,3 @@
 
 Rule ID | Missing Help Link | Title |
 --------|-------------------|-------|
-CA1873 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873> | Avoid potentially expensive logging |
-CA1874 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1874> | Use 'Regex.IsMatch' |
-CA1875 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1875> | Use 'Regex.Count' |
-CA2023 | <https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2023> | Invalid braces in message template |

src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp2.0.cs

@@ -14,7 +14,6 @@ internal static class NETCoreApp20
         internal static FrameworkPackages Instance { get; } = new(NetCoreApp20, FrameworkNames.NetCoreApp, NETStandard20.Instance)
         {
             { "Microsoft.CSharp", "4.4.0" },
-            { "Microsoft.NETCore.App", "2.0.0" },
             { "Microsoft.VisualBasic", "10.2.0" },
             { "Microsoft.Win32.Registry", "4.4.0" },
             { "runtime.any.System.Collections", "4.3.0" },

src/Tasks/Microsoft.NET.Build.Tasks/FrameworkPackages/FrameworkPackages.netcoreapp2.1.cs

@@ -14,7 +14,6 @@ internal static class NETCoreApp21
         internal static FrameworkPackages Instance { get; } = new(NetCoreApp21, FrameworkNames.NetCoreApp, NETCoreApp20.Instance)
         {
             { "Microsoft.CSharp", "4.5.0" },
-            { "Microsoft.NETCore.App", "2.1.0" },
             { "Microsoft.VisualBasic", "10.3.0" },
             { "Microsoft.Win32.Registry", "4.5.0" },
             { "System.Buffers", "4.6.1" },

src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets

@@ -55,11 +55,7 @@ Copyright (c) .NET Foundation. All rights reserved.
   <!-- Package pruning is expected to be enable for all TFMs for multi-targeted projects, so still generate the pruning data when RestoreEnablePackagePruning is '' which implies a multi-targeted project. -->
   <Target Name="AddPrunePackageReferences" BeforeTargets="CollectPrunePackageReferences"
           DependsOnTargets="ProcessFrameworkReferences"
-          Condition="('$(RestoreEnablePackagePruning)' == 'true' OR '$(RestoreEnablePackagePruning)' == '')
-          AND (('$(TargetFrameworkIdentifier)' == '.NETCoreApp'
-          AND '$(TargetFrameworkVersion)' != ''
-          AND $([MSBuild]::VersionGreaterThanOrEquals('$(TargetFrameworkVersion)', '3.0')))
-          OR ('$(TargetFrameworkIdentifier)' != '.NETCoreApp'))">
+          Condition="'$(RestoreEnablePackagePruning)' == 'true' OR '$(RestoreEnablePackagePruning)' == ''">
     <PropertyGroup>
       <PrunePackageDataRoot Condition="'$(PrunePackageDataRoot)' == ''">$(NetCoreRoot)\sdk\$(NETCoreSdkVersion)\PrunePackageData\</PrunePackageDataRoot>
       <PrunePackageTargetingPackRoots Condition="'$(PrunePackageTargetingPackRoots)' == ''">$(NetCoreTargetingPackRoot)</PrunePackageTargetingPackRoots>

test/Microsoft.NET.Build.Tests/GivenThatWeWantToResolveConflicts.cs

@@ -320,8 +320,8 @@ public void PlatformPackagesCanBePruned(bool prunePackages)
         [InlineData("net6.0")]
         [InlineData("netcoreapp3.1")]
         [InlineData("netcoreapp3.0")]
-        [InlineData("netcoreapp2.1", false)] //TODO: https://github.com/dotnet/sdk/issues/49917
-        [InlineData("netcoreapp2.0", false)] //TODO: https://github.com/dotnet/sdk/issues/49917
+        [InlineData("netcoreapp2.1", true)]
+        [InlineData("netcoreapp2.0", true)]
         [InlineData("netcoreapp1.1", false)]
         [InlineData("netcoreapp1.0", false)]
         [InlineData("netstandard2.1")]