ensure that the run commands operates on minimal verbosity by default (#50114)

Co-authored-by: Copilot <[email protected]>

Author: baronfel

src/Cli/dotnet/Commands/Run/RunCommand.cs

@@ -69,6 +69,12 @@ public class RunCommand
     public string? LaunchProfile { get; }
     public bool NoLaunchProfile { get; }
 
+    /// <summary>
+    /// The verbosity of the run-portion of this command specifically. If implicit builds are performed, they will always happen
+    /// at a quiet verbosity by default, but it's important that we enable separate verbosity for the run command itself.
+    /// </summary>
+    public VerbosityOptions RunCommandVerbosity { get; private set; }
+
     /// <summary>
     /// True to ignore command line arguments specified by launch profile.
     /// </summary>
@@ -208,7 +214,7 @@ internal bool TryGetLaunchProfileSettingsIfNeeded(out ProjectLaunchSettingsModel
             return true;
         }
 
-        if (MSBuildArgs.Verbosity?.IsQuiet() != true)
+        if (!RunCommandVerbosity.IsQuiet())
         {
             Reporter.Output.WriteLine(string.Format(CliCommandStrings.UsingLaunchSettingsFromMessage, launchSettingsPath));
         }
@@ -339,11 +345,20 @@ private MSBuildArgs SetupSilentBuildArgs(MSBuildArgs msbuildArgs)
     {
         msbuildArgs = msbuildArgs.CloneWithAdditionalArgs("-nologo");
 
-        if (msbuildArgs.Verbosity is null)
+        if (msbuildArgs.Verbosity is VerbosityOptions userVerbosity)
+        {
+            // if the user had a desired verbosity, we use that for the run command
+            RunCommandVerbosity = userVerbosity;
+            return msbuildArgs;
+        }
+        else
         {
+            // Apply defaults if the user didn't expressly set the verbosity.
+            // Setting RunCommandVerbosity to minimal ensures that we keep the previous launchsettings
+            // and related diagnostics messages on by default.
+            RunCommandVerbosity = VerbosityOptions.minimal;
             return msbuildArgs.CloneWithVerbosity(VerbosityOptions.quiet);
         }
-        return msbuildArgs;
     }
 
     internal ICommand GetTargetCommand(Func<ProjectCollection, ProjectInstance>? projectFactory)
@@ -356,7 +371,7 @@ internal ICommand GetTargetCommand(Func<ProjectCollection, ProjectInstance>? pro
             return CreateCommandForCscBuiltProgram(EntryPointFileFullPath);
         }
 
-        FacadeLogger? logger = LoggerUtility.DetermineBinlogger([..MSBuildArgs.OtherMSBuildArgs], "dotnet-run");
+        FacadeLogger? logger = LoggerUtility.DetermineBinlogger([.. MSBuildArgs.OtherMSBuildArgs], "dotnet-run");
         var project = EvaluateProject(ProjectFileFullPath, projectFactory, MSBuildArgs, logger);
         ValidatePreconditions(project);
         InvokeRunArgumentsTarget(project, NoBuild, logger, MSBuildArgs);

test/dotnet.Tests/CommandTests/Run/RunFileTests.cs

@@ -1597,7 +1597,8 @@ Hello from Program
                 Message: ''
                 """);
 
-        new DotnetCommand(Log, "run", "Program.cs")
+        // quiet runs here so that launch-profile useage messages don't impact test assertions
+        new DotnetCommand(Log, "run", "-v", "q", "Program.cs")
             .WithWorkingDirectory(testInstance.Path)
             .Execute()
             .Should().Pass()
@@ -1607,7 +1608,7 @@ Hello from Program
                 Message: 'PropertiesLaunchSettingsJson1'
                 """);
 
-        new DotnetCommand(Log, "run", "-lp", "TestProfile2", "Program.cs")
+        new DotnetCommand(Log, "run", "-v", "q", "-lp", "TestProfile2", "Program.cs")
             .WithWorkingDirectory(testInstance.Path)
             .Execute()
             .Should().Pass()
@@ -1634,7 +1635,8 @@ public void LaunchProfile_Multiple()
         File.WriteAllText(Path.Join(testInstance.Path, "Second.cs"), source);
         File.WriteAllText(Path.Join(testInstance.Path, "Second.run.json"), s_launchSettings.Replace("TestProfileMessage", "Second"));
 
-        new DotnetCommand(Log, "run", "First.cs")
+        // do these runs with quiet verbosity so that default run output doesn't impact the tests
+        new DotnetCommand(Log, "run", "-v", "q", "First.cs")
             .WithWorkingDirectory(testInstance.Path)
             .Execute()
             .Should().Pass()
@@ -1643,7 +1645,7 @@ Hello from First
                 Message: 'First1'
                 """);
 
-        new DotnetCommand(Log, "run", "Second.cs")
+        new DotnetCommand(Log, "run", "-v", "q",  "Second.cs")
             .WithWorkingDirectory(testInstance.Path)
             .Execute()
             .Should().Pass()