Skip to content

Commit 2543baa

Browse files
[VMR] Codeflow 4177291-4177291
[[ commit created by automation ]]
1 parent 4177291 commit 2543baa

File tree

9 files changed

+33
-34
lines changed

9 files changed

+33
-34
lines changed

Directory.Build.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
<HostOSName Condition="'$(HostOSName)' == '' AND $([MSBuild]::IsOSPlatform('ILLUMOS'))">illumos</HostOSName>
2424
<HostOSName Condition="'$(HostOSName)' == '' AND '$(IsLinux)' == 'true'">linux</HostOSName>
2525

26+
<OSName Condition="'$(OSName)' == '' AND $(PortableTargetRid) != ''">$(PortableTargetRid.Substring(0, $(PortableTargetRid.LastIndexOf('-'))))</OSName>
2627
<OSName Condition="'$(OSName)' == '' AND $(TargetRid) != ''">$(TargetRid.Substring(0, $(TargetRid.LastIndexOf('-'))))</OSName>
2728
<OSName Condition="'$(OSName)' == ''">$(HostOSName)</OSName>
2829
</PropertyGroup>

eng/Publishing.props

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
1414
These packages have already been signed by the FSharp build so we don't need to re-include them for signing. -->
1515
<PropertyGroup Condition="'$(EnableDefaultArtifacts)' == 'true'">
16-
<FSharpCorePath Condition="'$(DotNetFinalVersionKind)' != 'release'">Shipping</FSharpCorePath>
16+
<FSharpCorePath Condition="'$(DotNetFinalVersionKind)' == ''">Shipping</FSharpCorePath>
17+
<FSharpCorePath Condition="'$(DotNetFinalVersionKind)' == 'prerelease'">PreRelease</FSharpCorePath>
1718
<FSharpCorePath Condition="'$(DotNetFinalVersionKind)' == 'release'">Release</FSharpCorePath>
1819

1920
<!--

src/Layout/Directory.Build.props

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,8 @@
3333
<TargetRid Condition="'$(TargetRid)' == ''">$(OSName)-$(TargetArchitecture)</TargetRid>
3434
<ProductMonikerRid>$(TargetRid)</ProductMonikerRid>
3535

36-
<PortableOSName Condition="'$(PortableOSName)' == ''">$(OSName)</PortableOSName>
37-
<PortableRid>$(PortableOSName)-$(TargetArchitecture)</PortableRid>
38-
<PortableProductMonikerRid>$(PortableRid)</PortableProductMonikerRid>
36+
<PortableTargetRid Condition="'$(PortableTargetRid)' == ''">$(OSName)-$(TargetArchitecture)</PortableTargetRid>
37+
<PortableProductMonikerRid>$(PortableTargetRid)</PortableProductMonikerRid>
3938
</PropertyGroup>
4039

4140
<PropertyGroup>

src/Layout/pkg/dotnet-sdk.proj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<GenerateInstallers Condition="'$(DotNetBuildSourceOnly)' != 'true'">true</GenerateInstallers>
99
<BuildDebPackage Condition="'$(BuildSdkDeb)' == 'true'">true</BuildDebPackage>
1010
<BuildRpmPackage Condition="'$(BuildSdkRpm)' == 'true'">true</BuildRpmPackage>
11-
<UseArcadeRpmTooling>true</UseArcadeRpmTooling>
1211
<ProductBrandPrefix>Microsoft .NET</ProductBrandPrefix>
1312
<LicenseFile>$(RepoRoot)LICENSE.TXT</LicenseFile>
1413
<InstallerName>dotnet-sdk</InstallerName>
@@ -99,7 +98,7 @@
9998
</Target>
10099

101100
<Target Name="AddLinuxPackageInformation"
102-
BeforeTargets="GetDebInstallerJsonProperties;GetRpmInstallerJsonProperties"
101+
BeforeTargets="GetAdditionalLinuxInstallerProperties"
103102
DependsOnTargets="CalculateLinuxNativeInstallerDependencyVersions">
104103

105104
<PropertyGroup>

src/Layout/redist/targets/GenerateBundledVersions.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@
398398
win-x86;
399399
" />
400400

401-
<!-- ILCompiler target RIDs that are officially supported, plus the architecture we are building the product for (OutputRID). See:
401+
<!-- ILCompiler target RIDs that are officially supported, plus the architecture we are building the product for (TargetRid). See:
402402
https://github.com/dotnet/runtime/blob/main/src/installer/pkg/projects/Microsoft.DotNet.ILCompiler/ILCompilerRIDs.props -->
403403
<ILCompilerSupportedRids Include="
404404
@(Net90ILCompilerSupportedRids);

src/Layout/redist/targets/RestoreLayout.targets

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,12 @@
126126
PackageVersion="$(MicrosoftNETCoreAppRuntimePackageVersion)"
127127
RelativeLayoutPath="packs/%(PackageName)/%(PackageVersion)" />
128128

129+
<BundledLayoutPackage Include="Microsoft.NETCore.App.Runtime.NativeAOT.$(SharedFrameworkRid)"
130+
Condition="'$(BundleNativeAotCompiler)' == 'true'"
131+
PackageName="Microsoft.NETCore.App.Runtime.NativeAOT.$(SharedFrameworkRid)"
132+
PackageVersion="$(MicrosoftNETCoreAppRuntimePackageVersion)"
133+
RelativeLayoutPath="packs/%(PackageName)/%(PackageVersion)" />
134+
129135
<BundledLayoutPackage Include="Microsoft.DotNet.ILCompiler"
130136
Condition="'$(BundleNativeAotCompiler)' == 'true'"
131137
PackageName="Microsoft.DotNet.ILCompiler"

src/Layout/redist/tools/tool_fsc.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@
3030
<Target Name="_ResolvePublishNuGetPackagePdbsAndXml"
3131
AfterTargets="_ResolveCopyLocalAssetsForPublish">
3232
<PropertyGroup>
33-
<FSharpCorePath Condition="'$(DotNetFinalVersionKind)'!='release'">Shipping</FSharpCorePath>
33+
<FSharpCorePath Condition="'$(DotNetFinalVersionKind)'==''">Shipping</FSharpCorePath>
34+
<FSharpCorePath Condition="'$(DotNetFinalVersionKind)'=='prerelease'">PreRelease</FSharpCorePath>
3435
<FSharpCorePath Condition="'$(DotNetFinalVersionKind)'=='release'">Release</FSharpCorePath>
3536
<FSharpTfm>net9.0</FSharpTfm>
3637
<FSharpTfm Condition="'$(DotNetBuildSourceOnly)' == 'true' and '$(DotNetBuildFromVMR)' == 'true'">$(NetCurrent)</FSharpTfm>

src/RazorSdk/Tool/TagHelperDescriptorJsonConverter.cs

Lines changed: 17 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,6 @@ private static void WriteBoundAttribute(JsonWriter writer, BoundAttributeDescrip
170170
{
171171
writer.WriteStartObject();
172172

173-
writer.WritePropertyName(nameof(BoundAttributeDescriptor.Kind));
174-
writer.WriteValue(boundAttribute.Kind);
175-
176173
writer.WritePropertyName(nameof(BoundAttributeDescriptor.Name));
177174
writer.WriteValue(boundAttribute.Name);
178175

@@ -239,10 +236,13 @@ private static void WriteBoundAttributeParameter(JsonWriter writer, BoundAttribu
239236
writer.WritePropertyName(nameof(BoundAttributeParameterDescriptor.Name));
240237
writer.WriteValue(boundAttributeParameter.Name);
241238

239+
writer.WritePropertyName(nameof(BoundAttributeParameterDescriptor.PropertyName));
240+
writer.WriteValue(boundAttributeParameter.PropertyName);
241+
242242
writer.WritePropertyName(nameof(BoundAttributeParameterDescriptor.TypeName));
243243
writer.WriteValue(boundAttributeParameter.TypeName);
244244

245-
if (boundAttributeParameter.IsEnum != default)
245+
if (boundAttributeParameter.IsEnum)
246246
{
247247
writer.WritePropertyName(nameof(BoundAttributeParameterDescriptor.IsEnum));
248248
writer.WriteValue(boundAttributeParameter.IsEnum);
@@ -260,9 +260,6 @@ private static void WriteBoundAttributeParameter(JsonWriter writer, BoundAttribu
260260
serializer.Serialize(writer, boundAttributeParameter.Diagnostics);
261261
}
262262

263-
writer.WritePropertyName(nameof(BoundAttributeParameterDescriptor.Metadata));
264-
WriteMetadata(writer, boundAttributeParameter.Metadata);
265-
266263
writer.WriteEndObject();
267264
}
268265

@@ -347,12 +344,6 @@ private static void WriteRequiredAttribute(JsonWriter writer, RequiredAttributeD
347344
serializer.Serialize(writer, requiredAttribute.Diagnostics);
348345
}
349346

350-
if (requiredAttribute.Metadata != null && requiredAttribute.Metadata.Count > 0)
351-
{
352-
writer.WritePropertyName(nameof(RequiredAttributeDescriptor.Metadata));
353-
WriteMetadata(writer, requiredAttribute.Metadata);
354-
}
355-
356347
writer.WriteEndObject();
357348
}
358349

@@ -495,9 +486,9 @@ private static void ReadBoundAttributeParameter(JsonReader reader, BoundAttribut
495486

496487
builder.BindAttributeParameter(parameter =>
497488
{
498-
reader.ReadProperties(propertyName =>
489+
reader.ReadProperties(jsonPropertyName =>
499490
{
500-
switch (propertyName)
491+
switch (jsonPropertyName)
501492
{
502493
case nameof(BoundAttributeParameterDescriptor.Name):
503494
if (reader.Read())
@@ -506,6 +497,13 @@ private static void ReadBoundAttributeParameter(JsonReader reader, BoundAttribut
506497
parameter.Name = name;
507498
}
508499
break;
500+
case nameof(BoundAttributeParameterDescriptor.PropertyName):
501+
if (reader.Read())
502+
{
503+
var propertyName = (string)reader.Value;
504+
parameter.PropertyName = propertyName;
505+
}
506+
break;
509507
case nameof(BoundAttributeParameterDescriptor.TypeName):
510508
if (reader.Read())
511509
{
@@ -527,9 +525,6 @@ private static void ReadBoundAttributeParameter(JsonReader reader, BoundAttribut
527525
parameter.SetDocumentation(documentation);
528526
}
529527
break;
530-
case nameof(BoundAttributeParameterDescriptor.Metadata):
531-
ReadMetadata(reader, parameter.Metadata);
532-
break;
533528
case nameof(BoundAttributeParameterDescriptor.Diagnostics):
534529
ReadDiagnostics(reader, parameter.Diagnostics);
535530
break;
@@ -646,8 +641,8 @@ private static void ReadRequiredAttribute(JsonReader reader, TagMatchingRuleDesc
646641
}
647642
break;
648643
case nameof(RequiredAttributeDescriptor.NameComparison):
649-
var nameComparison = (RequiredAttributeDescriptor.NameComparisonMode)reader.ReadAsInt32();
650-
attribute.NameComparisonMode = nameComparison;
644+
var nameComparison = (RequiredAttributeNameComparison)reader.ReadAsInt32();
645+
attribute.NameComparison = nameComparison;
651646
break;
652647
case nameof(RequiredAttributeDescriptor.Value):
653648
if (reader.Read())
@@ -657,15 +652,12 @@ private static void ReadRequiredAttribute(JsonReader reader, TagMatchingRuleDesc
657652
}
658653
break;
659654
case nameof(RequiredAttributeDescriptor.ValueComparison):
660-
var valueComparison = (RequiredAttributeDescriptor.ValueComparisonMode)reader.ReadAsInt32();
661-
attribute.ValueComparisonMode = valueComparison;
655+
var valueComparison = (RequiredAttributeValueComparison)reader.ReadAsInt32();
656+
attribute.ValueComparison = valueComparison;
662657
break;
663658
case nameof(RequiredAttributeDescriptor.Diagnostics):
664659
ReadDiagnostics(reader, attribute.Diagnostics);
665660
break;
666-
case nameof(RequiredAttributeDescriptor.Metadata):
667-
ReadMetadata(reader, attribute.Metadata);
668-
break;
669661
}
670662
});
671663
});

src/Workloads/Manifests/Microsoft.NET.Workload.Emscripten.Current.Manifest/Microsoft.NET.Workload.Emscripten.Current.Manifest.proj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<ItemGroup>
1919
<_WorkloadManifestValues Include="NetVersion" Value="net10" />
2020
<_WorkloadManifestValues Include="WorkloadVersion" Value="$(PackageVersion)" />
21-
<_WorkloadManifestValues Include="EmsdkVersion" Value="$(MicrosoftNETRuntimeEmscriptenSdkInternalVersion)" />
21+
<_WorkloadManifestValues Include="EmsdkVersion" Value="$(MicrosoftNETCoreAppRuntimePackageVersion)" />
2222
<_WorkloadManifestValues Include="EmscriptenVersion" Value="$(EmscriptenVersionCurrent)" />
2323
</ItemGroup>
2424

0 commit comments

Comments
 (0)