Avoid double disposal of terminal logger

jjonescz · jjonescz · commit 3017955b5f3b · 2025-07-28T16:05:29.000+02:00
diff --git a/src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs b/src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs
@@ -340,6 +340,7 @@ public override int Execute()
             }
 
             BuildManager.DefaultBuildManager.EndBuild();
+            consoleLogger = null; // avoid double disposal which would throw
 
             return 0;
         }
@@ -356,7 +357,7 @@ public override int Execute()
             }
 
             binaryLogger?.Value.ReallyShutdown();
-            consoleLogger.Shutdown();
+            consoleLogger?.Shutdown();
         }
 
         static Action<IDictionary<string, string>> AddRestoreGlobalProperties(ReadOnlyDictionary<string, string>? restoreProperties)

Original file line number	Diff line number	Diff line change
`@@ -340,6 +340,7 @@ public override int Execute()`
`340`	`340`	`}`
`341`	`341`
`342`	`342`	`BuildManager.DefaultBuildManager.EndBuild();`
	`343`	`+ consoleLogger = null; // avoid double disposal which would throw`
`343`	`344`
`344`	`345`	`return 0;`
`345`	`346`	`}`
`@@ -356,7 +357,7 @@ public override int Execute()`
`356`	`357`	`}`
`357`	`358`
`358`	`359`	`binaryLogger?.Value.ReallyShutdown();`
`359`		`- consoleLogger.Shutdown();`
	`360`	`+ consoleLogger?.Shutdown();`
`360`	`361`	`}`
`361`	`362`
`362`	`363`	`static Action<IDictionary<string, string>> AddRestoreGlobalProperties(ReadOnlyDictionary<string, string>? restoreProperties)`