check if containerd store is enabled before loading

Author: Surayya Huseyn Zada

src/Containers/Microsoft.NET.Build.Containers/ImagePublisher.cs

@@ -72,8 +72,7 @@ await PushToLocalRegistryAsync(
                     BuildEngine,
                     telemetry,
                     cancellationToken,
-                    destinationImageReference.LocalRegistry!.LoadAsync,
-                    logTipAboutContainerd : true).ConfigureAwait(false);
+                    destinationImageReference.LocalRegistry!.LoadAsync).ConfigureAwait(false);
                 break;
             case DestinationImageReferenceKind.RemoteRegistry:
                 await PushToRemoteRegistryAsync(
@@ -110,8 +109,7 @@ private static async Task PushToLocalRegistryAsync<T>(
         IBuildEngine? BuildEngine,
         Telemetry telemetry,
         CancellationToken cancellationToken,
-        Func<T, SourceImageReference, DestinationImageReference, CancellationToken, Task> loadFunc,
-        bool logTipAboutContainerd = false)
+        Func<T, SourceImageReference, DestinationImageReference, CancellationToken, Task> loadFunc)
     {
         ILocalRegistry localRegistry = destinationImageReference.LocalRegistry!;
         if (!(await localRegistry.IsAvailableAsync(cancellationToken).ConfigureAwait(false)))
@@ -148,10 +146,6 @@ private static async Task PushToLocalRegistryAsync<T>(
         {
             telemetry.LogLocalLoadError();
             Log.LogErrorFromException(dle, showStackTrace: false);
-            if (logTipAboutContainerd && dle.Message.Contains("no such file or directory"))
-            {
-                Log.LogMessage(MessageImportance.High, Strings.TipToEnableContainerdForMultiArch);
-            }
         }
     }
 

src/Containers/Microsoft.NET.Build.Containers/LocalDaemons/DockerCli.cs

@@ -87,10 +87,16 @@ private async Task LoadAsync<T>(
         SourceImageReference sourceReference,
         DestinationImageReference destinationReference,
         Func<T, SourceImageReference, DestinationImageReference, Stream, CancellationToken, Task> writeStreamFunc,
-        CancellationToken cancellationToken)
+        CancellationToken cancellationToken,
+        bool checkContainerdStore = false)
     {
         cancellationToken.ThrowIfCancellationRequested();
 
+        if (checkContainerdStore && !IsContainerdStoreEnabledForDocker())
+        {
+            throw new DockerLoadException(Strings.ImageLoadFailed_ContainerdStoreDisabled);
+        }
+
         string commandPath = await FindFullCommandPath(cancellationToken);
 
         // call `docker load` and get it ready to receive input
@@ -125,7 +131,7 @@ public async Task LoadAsync(BuiltImage image, SourceImageReference sourceReferen
         => await LoadAsync(image, sourceReference, destinationReference, WriteDockerImageToStreamAsync, cancellationToken);
 
     public async Task LoadAsync(BuiltImage[] images, SourceImageReference sourceReference, DestinationImageReference destinationReference, CancellationToken cancellationToken) 
-        => await LoadAsync(images, sourceReference, destinationReference, WriteMultiArchOciImageToStreamAsync, cancellationToken);
+        => await LoadAsync(images, sourceReference, destinationReference, WriteMultiArchOciImageToStreamAsync, cancellationToken, checkContainerdStore: true);
 
     public async Task<bool> IsAvailableAsync(CancellationToken cancellationToken)
     {
@@ -619,6 +625,37 @@ private static bool IsPodmanAlias()
         }
     }
 
+    private static bool IsContainerdStoreEnabledForDocker()
+    {
+        try
+        {
+            // We don't need to check if this is docker, because there is no "DriverStatus" for podman
+            if (!GetDockerConfig().RootElement.TryGetProperty("DriverStatus", out var driverStatus) || driverStatus.ValueKind != JsonValueKind.Array)
+            {
+                return false;
+            }
+
+            foreach (var item in driverStatus.EnumerateArray())
+            {
+                if (item.ValueKind != JsonValueKind.Array || item.GetArrayLength() != 2) continue;
+
+                var array = item.EnumerateArray().ToArray();
+                // The usual output is [driver-type io.containerd.snapshotter.v1]
+                if (array[0].GetString() == "driver-type" && array[1].GetString()!.StartsWith("io.containerd.snapshotter"))
+                {
+                    return true;
+                }
+            }
+
+            return false;
+        }
+        catch
+        {
+            return false;
+        }
+    }
+
+
 #if NET
     private async Task<bool> TryRunVersionCommandAsync(string command, CancellationToken cancellationToken)
     {

src/Containers/Microsoft.NET.Build.Containers/Resources/Strings.Designer.cs

@@ -189,6 +189,10 @@
     <value>CONTAINER1009: Failed to load image from local registry. stdout: {0}</value>
     <comment>{StrBegin="CONTAINER1009: "}</comment>
   </data>
+  <data name="ImageLoadFailed_ContainerdStoreDisabled" xml:space="preserve">
+    <value>CONTAINER1020: Failed to load image because containerd image store is not enabled for Docker. Tip: You can enable it by checking 'Use containerd for pulling and storing images' in Docker Desktop settings.</value>
+    <comment>{StrBegin="CONTAINER1020: "}</comment>
+  </data>
   <data name="InvalidEnvVar" xml:space="preserve">
     <value>CONTAINER2015: {0}: '{1}' was not a valid Environment Variable. Ignoring.</value>
     <comment>{StrBegin="CONTAINER2015: "}</comment>
@@ -401,10 +405,6 @@
     <value>Image index creation for Podman is not supported.</value>
     <comment/>
   </data>
-  <data name="TipToEnableContainerdForMultiArch" xml:space="preserve">
-    <value>Tip: For multi-arch image publishing, ensure that 'Use containerd for pulling and storing images' is checked in Docker Desktop settings.</value>
-    <comment/>
-  </data>
   <data name="LocalDocker_FailedToGetConfig" xml:space="preserve">
     <value>Error while reading daemon config: {0}</value>
     <comment>{0} is the exception message that ends with period</comment>