Improve AppendAssemblyResult (#50057)

Author: Youssef1313

src/Cli/dotnet/Commands/Test/Terminal/TerminalTestReporter.cs

@@ -427,28 +427,21 @@ private void AppendExitCodeAndUrl(ITerminal terminal, int? exitCode, bool isRun)
     /// <summary>
     /// Print a build result summary to the output.
     /// </summary>
-    private static void AppendAssemblyResult(ITerminal terminal, bool succeeded, int countErrors, int countWarnings)
+    private static void AppendAssemblyResult(ITerminal terminal, TestProgressState state)
     {
-        if (!succeeded)
+        if (!state.Success)
         {
             terminal.SetColor(TerminalColor.DarkRed);
             // If the build failed, we print one of three red strings.
-            string text = (countErrors > 0, countWarnings > 0) switch
+            string text = (state.FailedTests > 0, state.TotalTests == 0) switch
             {
-                (true, true) => string.Format(CultureInfo.CurrentCulture, CliCommandStrings.FailedWithErrorsAndWarnings, countErrors, countWarnings),
-                (true, _) => string.Format(CultureInfo.CurrentCulture, CliCommandStrings.FailedWithErrors, countErrors),
-                (false, true) => string.Format(CultureInfo.CurrentCulture, CliCommandStrings.FailedWithWarnings, countWarnings),
-                _ => CliCommandStrings.FailedLowercase,
+                (true, _) => string.Format(CultureInfo.CurrentCulture, CliCommandStrings.FailedWithErrors, state.FailedTests),
+                (false, true) => CliCommandStrings.ZeroTestsRan,
+                (false, false) => CliCommandStrings.FailedLowercase,
             };
             terminal.Append(text);
             terminal.ResetColor();
         }
-        else if (countWarnings > 0)
-        {
-            terminal.SetColor(TerminalColor.DarkYellow);
-            terminal.Append($"succeeded with {countWarnings} warning(s)");
-            terminal.ResetColor();
-        }
         else
         {
             terminal.SetColor(TerminalColor.DarkGreen);
@@ -858,12 +851,10 @@ void AppendOutputWhenPresent(string description, string? output)
     private static void AppendAssemblySummary(TestProgressState assemblyRun, ITerminal terminal)
     {
         terminal.ResetColor();
-        int failedTests = assemblyRun.FailedTests;
-        int warnings = 0;
-
+        
         AppendAssemblyLinkTargetFrameworkAndArchitecture(terminal, assemblyRun.Assembly, assemblyRun.TargetFramework, assemblyRun.Architecture);
         terminal.Append(' ');
-        AppendAssemblyResult(terminal, assemblyRun.Success, failedTests, warnings);
+        AppendAssemblyResult(terminal, assemblyRun);
         terminal.Append(' ');
         AppendLongDuration(terminal, assemblyRun.Stopwatch.Elapsed);
         terminal.AppendLine();

test/Microsoft.NET.TestFramework/Constants.cs

@@ -10,6 +10,7 @@ internal static class TestingConstants
 
         public const string Failed = "failed";
         public const string Passed = "passed";
+        public const string ZeroTestsRan = "Zero tests ran";
     }
 
     internal static class ExitCode

test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTests.cs

@@ -225,7 +225,7 @@ public void RunMultipleTestProjectsWithDifferentFailures_ShouldReturnExitCodeGen
 
             if (!TestContext.IsLocalized())
             {
-                Assert.Matches(RegexPatternHelper.GenerateProjectRegexPattern("TestProject", TestingConstants.Failed, true, configuration, "8"), result.StdOut);
+                Assert.Matches(RegexPatternHelper.GenerateProjectRegexPattern("TestProject", TestingConstants.ZeroTestsRan, true, configuration, "8"), result.StdOut);
                 Assert.Matches(RegexPatternHelper.GenerateProjectRegexPattern("OtherTestProject", TestingConstants.Failed, true, configuration, "2"), result.StdOut);
                 Assert.Matches(RegexPatternHelper.GenerateProjectRegexPattern("AnotherTestProject", TestingConstants.Failed, true, configuration, "9"), result.StdOut);