Change MaxParallelTestModulesOption to int (#50548)

mariam-abdulla · web-flow · commit 3afdcd1bbbc6 · 2025-08-29T12:51:29.000+02:00
diff --git a/src/Cli/dotnet/Commands/Test/TestingPlatformCommand.cs b/src/Cli/dotnet/Commands/Test/TestingPlatformCommand.cs
@@ -177,7 +177,8 @@ private void InitializeTestExecutionActionQueue(int degreeOfParallelism, TestOpt
 
     private static int GetDegreeOfParallelism(ParseResult parseResult)
     {
-        if (!int.TryParse(parseResult.GetValue(TestingPlatformOptions.MaxParallelTestModulesOption), out int degreeOfParallelism) || degreeOfParallelism <= 0)
+        var degreeOfParallelism = parseResult.GetValue(TestingPlatformOptions.MaxParallelTestModulesOption);
+        if (degreeOfParallelism <= 0)
             degreeOfParallelism = Environment.ProcessorCount;
         return degreeOfParallelism;
     }
diff --git a/src/Cli/dotnet/Commands/Test/TestingPlatformOptions.cs b/src/Cli/dotnet/Commands/Test/TestingPlatformOptions.cs
@@ -56,7 +56,7 @@ internal static class TestingPlatformOptions
         Arity = ArgumentArity.ExactlyOne
     };
 
-    public static readonly Option<string> MaxParallelTestModulesOption = new("--max-parallel-test-modules")
+    public static readonly Option<int> MaxParallelTestModulesOption = new("--max-parallel-test-modules")
     {
         Description = CliCommandStrings.CmdMaxParallelTestModulesDescription,
         HelpName = CliCommandStrings.CmdNumberName

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,8 @@ private void InitializeTestExecutionActionQueue(int degreeOfParallelism, TestOpt`
`177`	`177`
`178`	`178`	`private static int GetDegreeOfParallelism(ParseResult parseResult)`
`179`	`179`	`{`
`180`		`- if (!int.TryParse(parseResult.GetValue(TestingPlatformOptions.MaxParallelTestModulesOption), out int degreeOfParallelism) \|\| degreeOfParallelism <= 0)`
	`180`	`+ var degreeOfParallelism = parseResult.GetValue(TestingPlatformOptions.MaxParallelTestModulesOption);`
	`181`	`+ if (degreeOfParallelism <= 0)`
`181`	`182`	`degreeOfParallelism = Environment.ProcessorCount;`
`182`	`183`	`return degreeOfParallelism;`
`183`	`184`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ internal static class TestingPlatformOptions`
`56`	`56`	`Arity = ArgumentArity.ExactlyOne`
`57`	`57`	`};`
`58`	`58`
`59`		`- public static readonly Option<string> MaxParallelTestModulesOption = new("--max-parallel-test-modules")`
	`59`	`+ public static readonly Option<int> MaxParallelTestModulesOption = new("--max-parallel-test-modules")`
`60`	`60`	`{`
`61`	`61`	`Description = CliCommandStrings.CmdMaxParallelTestModulesDescription,`
`62`	`62`	`HelpName = CliCommandStrings.CmdNumberName`