Skip to content

Commit 3cb3c34

Browse files
committed
Retarget some of the ILLink tests to 8+ as the runtimes for these tests were going over 1 minute. Because of how we split up tests, even a few longer tests with a lots of params can extend a test leg.
1 parent 9ca8236 commit 3cb3c34

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

test/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public void ILLink_runs_and_creates_linked_app(string targetFramework, bool refe
9696
}
9797

9898
[RequiresMSBuildVersionTheory("17.0.0.32901")]
99-
[MemberData(nameof(SupportedTfms), MemberType = typeof(PublishTestUtils))]
99+
[MemberData(nameof(Net8Plus), MemberType = typeof(PublishTestUtils))]
100100
public void ILLink_links_simple_app_without_analysis_warnings_and_it_runs(string targetFramework)
101101
{
102102
foreach (var trimMode in new[] { "copyused", "link" })
@@ -248,7 +248,7 @@ public void ILLink_can_use_latest_with_unsupported_target_framework(string targe
248248
}
249249

250250
[RequiresMSBuildVersionTheory("17.0.0.32901")]
251-
[MemberData(nameof(SupportedTfms), MemberType = typeof(PublishTestUtils))]
251+
[MemberData(nameof(Net8Plus), MemberType = typeof(PublishTestUtils))]
252252
public void PrepareForILLink_can_set_IsTrimmable(string targetFramework)
253253
{
254254
var projectName = "HelloWorld";
@@ -1192,7 +1192,7 @@ public void ILLink_ignores_host_config_settings_with_link_false()
11921192
}
11931193

11941194
[RequiresMSBuildVersionTheory("17.0.0.32901")]
1195-
[MemberData(nameof(SupportedTfms), MemberType = typeof(PublishTestUtils))]
1195+
[MemberData(nameof(Net8Plus), MemberType = typeof(PublishTestUtils))]
11961196
public void ILLink_runs_incrementally(string targetFramework)
11971197
{
11981198
var projectName = "HelloWorld";
@@ -1295,7 +1295,7 @@ public void ILLink_net7_defaults_trim_nonframework()
12951295
}
12961296

12971297
[RequiresMSBuildVersionTheory("17.0.0.32901")]
1298-
[MemberData(nameof(SupportedTfms), MemberType = typeof(PublishTestUtils))]
1298+
[MemberData(nameof(Net8Plus), MemberType = typeof(PublishTestUtils))]
12991299
public void ILLink_does_not_include_leftover_artifacts_on_second_run(string targetFramework)
13001300
{
13011301
var projectName = "HelloWorld";
@@ -1381,7 +1381,7 @@ public void ILLink_keeps_symbols_by_default(string targetFramework)
13811381
}
13821382

13831383
[RequiresMSBuildVersionTheory("17.0.0.32901")]
1384-
[MemberData(nameof(SupportedTfms), MemberType = typeof(PublishTestUtils))]
1384+
[MemberData(nameof(Net8Plus), MemberType = typeof(PublishTestUtils))]
13851385
public void ILLink_removes_symbols_when_debugger_support_is_disabled(string targetFramework)
13861386
{
13871387
var projectName = "HelloWorld";
@@ -1409,7 +1409,7 @@ public void ILLink_removes_symbols_when_debugger_support_is_disabled(string targ
14091409
}
14101410

14111411
[RequiresMSBuildVersionTheory("17.0.0.32901")]
1412-
[MemberData(nameof(SupportedTfms), MemberType = typeof(PublishTestUtils))]
1412+
[MemberData(nameof(Net8Plus), MemberType = typeof(PublishTestUtils))]
14131413
public void ILLink_accepts_option_to_remove_symbols(string targetFramework)
14141414
{
14151415
var projectName = "HelloWorld";
@@ -1660,7 +1660,7 @@ public void ILLink_dont_display_informational_warning_by_default_on_net6plus(str
16601660
}
16611661

16621662
[RequiresMSBuildVersionTheory("17.0.0.32901")]
1663-
[MemberData(nameof(SupportedTfms), MemberType = typeof(PublishTestUtils))]
1663+
[MemberData(nameof(Net8Plus), MemberType = typeof(PublishTestUtils))]
16641664
public void ILLink_dont_display_time_awareness_message_on_incremental_build(string targetFramework)
16651665
{
16661666
var projectName = "HelloWorld";

0 commit comments

Comments
 (0)