Skip to content

Commit 483fca0

Browse files
authored
Make CA2025 DoNotPassDisposablesIntoUnawaitedTasks analyzer opt-in (#7689)
* Make CA2025 DoNotPassDisposablesIntoUnawaitedTasks analyzer opt-in We've seen a couple false positives and exceptions like dotnet/roslyn-analyzers#7652 (comment), make the analyzer disabled by default until those issues are fixed. * Fix Microsoft.CodeAnalysis.NetAnalyzers.sarif and AnalyzerReleases.Unshipped.md
1 parent a99d420 commit 483fca0

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2137,7 +2137,7 @@ Unawaited tasks that use 'IDisposable' instances may use those instances long af
21372137
|Item|Value|
21382138
|-|-|
21392139
|Category|Reliability|
2140-
|Enabled|True|
2140+
|Enabled|False|
21412141
|Severity|Warning|
21422142
|CodeFix|False|
21432143
---

src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.sarif

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3819,7 +3819,7 @@
38193819
"helpUri": "https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2025",
38203820
"properties": {
38213821
"category": "Reliability",
3822-
"isEnabledByDefault": true,
3822+
"isEnabledByDefault": false,
38233823
"typeName": "DoNotPassDisposablesIntoUnawaitedTasksAnalyzer",
38243824
"languages": [
38253825
"C#",

src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers/AnalyzerReleases.Unshipped.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ CA1874 | Performance | Info | UseRegexMembers, [Documentation](https://learn.mic
99
CA1875 | Performance | Info | UseRegexMembers, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1875)
1010
CA2023 | Reliability | Warning | LoggerMessageDefineAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2023)
1111
CA2024 | Reliability | Warning | DoNotUseEndOfStreamInAsyncMethods, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2024)
12-
CA2025 | Reliability | Warning | DoNotPassDisposablesIntoUnawaitedTasksAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2025)
12+
CA2025 | Reliability | Disabled | DoNotPassDisposablesIntoUnawaitedTasksAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2025)

src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers/Microsoft.CodeQuality.Analyzers/QualityGuidelines/DoNotPassDisposablesIntoUnawaitedTasks.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public sealed class DoNotPassDisposablesIntoUnawaitedTasksAnalyzer : DiagnosticA
2727
CreateLocalizableResourceString(nameof(DoNotPassDisposablesIntoUnawaitedTasksTitle)),
2828
CreateLocalizableResourceString(nameof(DoNotPassDisposablesIntoUnawaitedTasksMessage)),
2929
DiagnosticCategory.Reliability,
30-
RuleLevel.BuildWarning,
30+
RuleLevel.Disabled,
3131
description: CreateLocalizableResourceString(nameof(DoNotPassDisposablesIntoUnawaitedTasksDescription)),
3232
isPortedFxCopRule: false,
3333
isDataflowRule: false);

0 commit comments

Comments
 (0)