Remove nullable disable warnings (#48846)

Author: jaredpar

src/Cli/dotnet/CommandFactory/CommandSpec.cs

@@ -1,20 +1,18 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable warnings
-
 using Microsoft.DotNet.Cli.CommandFactory.CommandResolution;
 
 namespace Microsoft.DotNet.Cli.CommandFactory;
 
 public class CommandSpec(
-    string? path,
+    string path,
     string? args,
-    Dictionary<string, string> environmentVariables = null)
+    Dictionary<string, string>? environmentVariables = null)
 {
     public string Path { get; } = path;
 
-    public string Args { get; } = args;
+    public string? Args { get; } = args;
 
     public Dictionary<string, string> EnvironmentVariables { get; } = environmentVariables ?? [];
 

src/Cli/dotnet/Commands/New/DotnetCommandCallbacks.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable warnings
-
 using Microsoft.DotNet.Cli.Commands.Hidden.Add;
 using Microsoft.DotNet.Cli.Commands.Package.Add;
 using Microsoft.DotNet.Cli.Commands.Reference.Add;

src/Cli/dotnet/Commands/New/MSBuildEvaluation/CapabilityExpressionEvaluator.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable warnings
-
 namespace Microsoft.DotNet.Cli.Commands.New.MSBuildEvaluation;
 
 /// <remarks>

src/Cli/dotnet/Commands/New/MSBuildEvaluation/MSBuildEvaluationResult.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable warnings
-
 using MSBuildProject = Microsoft.Build.Evaluation.Project;
 
 namespace Microsoft.DotNet.Cli.Commands.New.MSBuildEvaluation;

src/Cli/dotnet/Commands/New/MSBuildEvaluation/MSBuildEvaluator.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable warnings
-
 using System.Diagnostics;
 using Microsoft.Build.Evaluation;
 using Microsoft.DotNet.Cli.Utils;
@@ -197,7 +195,7 @@ private MSBuildEvaluationResult EvaluateProjectInternal(IEngineEnvironmentSettin
                 targetFrameworksString = Sha256Hasher.HashWithNormalizedCasing(targetFramework);
             }
 
-            Dictionary<string, string> properties = new()
+            Dictionary<string, string?> properties = new()
             {
                 { "ProjectPath",  Sha256Hasher.HashWithNormalizedCasing(projectPath)},
                 { "SdkStyleProject", IsSdkStyleProject.ToString() },

src/Cli/dotnet/Commands/New/MSBuildEvaluation/MultiTargetEvaluationResult.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable warnings
-
 using MSBuildProject = Microsoft.Build.Evaluation.Project;
 
 namespace Microsoft.DotNet.Cli.Commands.New.MSBuildEvaluation;

src/Cli/dotnet/Commands/New/MSBuildEvaluation/NonSDKStyleEvaluationResult.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable warnings
-
 using MSBuildProject = Microsoft.Build.Evaluation.Project;
 
 namespace Microsoft.DotNet.Cli.Commands.New.MSBuildEvaluation;

src/Cli/dotnet/Commands/New/MSBuildEvaluation/ProjectCapabilityConstraint.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable warnings
-
 using Microsoft.Build.Evaluation;
 using Microsoft.Extensions.Logging;
 using Microsoft.TemplateEngine.Abstractions;

src/Cli/dotnet/Commands/New/MSBuildEvaluation/ProjectContextSymbolSource.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable warnings
-
 using Microsoft.Extensions.Logging;
 using Microsoft.TemplateEngine.Abstractions;
 using Microsoft.TemplateEngine.Abstractions.Components;

src/Cli/dotnet/Commands/New/NewCommandParser.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable warnings
-
 using System.CommandLine;
 using System.CommandLine.Parsing;
 using Microsoft.DotNet.Cli.Commands.New.MSBuildEvaluation;
@@ -170,7 +168,7 @@ private static CliTemplateEngineHost CreateHost(
             { "prefs:language", preferredLang },
             { "dotnet-cli-version", Product.Version },
             { "RuntimeFrameworkVersion", new Muxer().SharedFxVersion },
-            { "NetStandardImplicitPackageVersion", new FrameworkDependencyFile().GetNetStandardLibraryVersion() },
+            { "NetStandardImplicitPackageVersion", new FrameworkDependencyFile().GetNetStandardLibraryVersion() ?? "" },
         };
         return new CliTemplateEngineHost(
             HostIdentifier,