Skip to content

Commit 50e4bcf

Browse files
authored
Apply suggestions from code review
1 parent 8b82d23 commit 50e4bcf

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1298,18 +1298,18 @@ Copyright (c) .NET Foundation. All rights reserved.
12981298
<_UseAttributeForTargetFrameworkInfoPropertyNames Condition="$([MSBuild]::VersionGreaterThanOrEquals($(MSBuildVersion), '17.0'))">true</_UseAttributeForTargetFrameworkInfoPropertyNames>
12991299
</PropertyGroup>
13001300

1301-
<Target Name="_CalculateIsVSTest">
1301+
<Target Name="_CalculateIsVSTestTestProject">
13021302
<PropertyGroup>
1303-
<_IsVSTest Condition="'$(IsTestProject)' == 'true' and '$(IsTestingPlatformApplication)' != 'true'">true</_IsVSTest>
1304-
<_IsVSTest Condition="'$(_IsVSTest)' == ''">false</_IsVSTest>
1303+
<_IsVSTestTestProject Condition="'$(IsTestProject)' == 'true' and '$(IsTestingPlatformApplication)' != 'true'">true</_IsVSTestTestProject>
1304+
<_IsVSTestTestProject Condition="'$(_IsVSTestTestProject)' == ''">false</_IsVSTestTestProject>
13051305

13061306
<!-- Don't generate an error if an Exe project references a test project. -->
1307-
<ShouldBeValidatedAsExecutableReference Condition="'$(_IsVSTest)' == 'true'">false</ShouldBeValidatedAsExecutableReference>
1307+
<ShouldBeValidatedAsExecutableReference Condition="'$(_IsVSTestTestProject)' == 'true'">false</ShouldBeValidatedAsExecutableReference>
13081308

13091309
<!-- Don't generate an error if a test project references a self-contained Exe. Test projects
13101310
use an OutputType of Exe but will usually call APIs in a referenced Exe rather than try
13111311
to run it. -->
1312-
<ValidateExecutableReferencesMatchSelfContained Condition="'$(_IsVSTest)' == 'true' And '$(ValidateExecutableReferencesMatchSelfContained)' == ''">false</ValidateExecutableReferencesMatchSelfContained>
1312+
<ValidateExecutableReferencesMatchSelfContained Condition="'$(_IsVSTestTestProject)' == 'true' And '$(ValidateExecutableReferencesMatchSelfContained)' == ''">false</ValidateExecutableReferencesMatchSelfContained>
13131313
</PropertyGroup>
13141314
</Target>
13151315

@@ -1324,7 +1324,7 @@ Copyright (c) .NET Foundation. All rights reserved.
13241324
</Target>
13251325

13261326
<Target Name="ValidateExecutableReferencesCore"
1327-
DependsOnTargets="_CalculateIsVSTest;ValidateExecutableReferences"
1327+
DependsOnTargets="_CalculateIsVSTestTestProject;ValidateExecutableReferences"
13281328
AfterTargets="_GetProjectReferenceTargetFrameworkProperties">
13291329

13301330
</Target>

0 commit comments

Comments
 (0)