Skip to content

Commit 565f5dd

Browse files
authored
Remove xliff-tasks from source-mappings.json (#48628)
1 parent b688c4e commit 565f5dd

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

eng/Version.Details.xml

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -681,25 +681,6 @@
681681
<Uri>https://github.com/dotnet/arcade-services</Uri>
682682
<Sha>f960530233dc3a37398aabc056109f55f897e2ad</Sha>
683683
</Dependency>
684-
<!--
685-
Aspire isn't really a toolset dependency. However, it only inserts a baseline manifest in sdk,
686-
and if you squint at it, this means we can say that its specific dependency versions don't matter to sdk.
687-
It also doesn't currently ship 9.0 preview versions, meaning the version is locked to the latest shipped from 8.0 era.
688-
Avoiding this as a product dependency avoids a long coherency path (aspnetcore->extensions->aspire->sdk).
689-
**It is** of course possible that an incoherent aspire means that aspire depends on versions of extensions that
690-
aren't shipping, or those extensions packages depend on aspnetcore packages that won't ship. However, given the cost
691-
of maintaining this coherency path is high. This being toolset means that aspire is responsible for its own coherency.
692-
-->
693-
<Dependency Name="Microsoft.NET.Sdk.Aspire.Manifest-8.0.100" Version="8.2.2">
694-
<Uri>https://github.com/dotnet/aspire</Uri>
695-
<Sha>5fa9337a84a52e9bd185d04d156eccbdcf592f74</Sha>
696-
</Dependency>
697-
<!-- Intermediate is necessary for source build. -->
698-
<Dependency Name="Microsoft.SourceBuild.Intermediate.aspire" Version="8.2.2-preview.1.24521.5">
699-
<Uri>https://github.com/dotnet/aspire</Uri>
700-
<Sha>5fa9337a84a52e9bd185d04d156eccbdcf592f74</Sha>
701-
<SourceBuild RepoName="aspire" ManagedOnly="true" />
702-
</Dependency>
703684
<Dependency Name="Microsoft.Testing.Platform" Version="1.7.0-preview.25217.2">
704685
<Uri>https://github.com/microsoft/testfx</Uri>
705686
<Sha>b1ee076771c0c039b9393e5adc51e4d6b11538be</Sha>

src/VirtualMonoRepo/source-mappings.json

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -176,17 +176,6 @@
176176
"name": "xdt",
177177
"defaultRemote": "https://github.com/dotnet/xdt"
178178
},
179-
{
180-
// TODO: Remove the xliff-tasks mapping once the synchronization flags it as unused
181-
// We no longer synchronize it but we can't remove it yet until
182-
// it disappears from all of the Version.Details.xml files.
183-
// https://github.com/dotnet/source-build/issues/4359
184-
"name": "xliff-tasks",
185-
"defaultRemote": "https://github.com/dotnet/xliff-tasks",
186-
"ignoreDefaults": true,
187-
"exclude": [ "**/*" ],
188-
"disableSynchronization": true
189-
},
190179
{
191180
"name": "winforms",
192181
"defaultRemote": "https://github.com/dotnet/winforms",

0 commit comments

Comments
 (0)