Skip to content

Commit 569fffc

Browse files
authored
Fix productCommit(.txt|.json) content in VMR (#48249)
1 parent ef85295 commit 569fffc

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

src/Layout/redist/targets/GenerateBundledVersions.targets

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,28 +17,32 @@
1717

1818
<GetDependencyInfo
1919
VersionDetailsXmlFile="$(RepositoryEngineeringDir)Version.Details.xml"
20-
DependencyName="Microsoft.NETCore.App.Ref">
20+
DependencyName="Microsoft.NETCore.App.Ref"
21+
Condition="'$(DotNetBuild)' != 'true'">
2122
<Output TaskParameter="DependencyVersion" PropertyName="DepRuntimeVersion" />
2223
<Output TaskParameter="DependencyCommit" PropertyName="DepRuntimeCommit" />
2324
</GetDependencyInfo>
2425

2526
<GetDependencyInfo
2627
VersionDetailsXmlFile="$(RepositoryEngineeringDir)Version.Details.xml"
27-
DependencyName="Microsoft.AspNetCore.App.Ref">
28+
DependencyName="Microsoft.AspNetCore.App.Ref"
29+
Condition="'$(DotNetBuild)' != 'true'">
2830
<Output TaskParameter="DependencyVersion" PropertyName="DepAspNetCoreVersion" />
2931
<Output TaskParameter="DependencyCommit" PropertyName="DepAspNetCoreCommit" />
3032
</GetDependencyInfo>
33+
3134
<GetDependencyInfo
3235
VersionDetailsXmlFile="$(RepositoryEngineeringDir)Version.Details.xml"
33-
DependencyName="Microsoft.WindowsDesktop.App.Ref">
36+
DependencyName="Microsoft.WindowsDesktop.App.Ref"
37+
Condition="'$(DotNetBuild)' != 'true'">
3438
<Output TaskParameter="DependencyVersion" PropertyName="DepWindowsDesktopVersion" />
3539
<Output TaskParameter="DependencyCommit" PropertyName="DepWindowsDesktopCommit" />
3640
</GetDependencyInfo>
3741

3842
<ItemGroup Label="Version info">
39-
<Line Include="runtime" Version="$(DepRuntimeVersion)" Commit="$(DepRuntimeCommit)" />
40-
<Line Include="aspnetcore" Version="$(DepAspNetCoreVersion)" Commit="$(DepAspNetCoreCommit)" />
41-
<Line Include="windowsdesktop" Version="$(DepWindowsDesktopVersion)" Commit="$(DepWindowsDesktopCommit)" />
43+
<Line Include="runtime" Version="$(MicrosoftNETCoreAppRefPackageVersion)" Commit="$([MSBuild]::ValueOrDefault('$(DepRuntimeCommit)', '$(BUILD_SOURCEVERSION)'))" />
44+
<Line Include="aspnetcore" Version="$(MicrosoftAspNetCoreAppRefPackageVersion)" Commit="$([MSBuild]::ValueOrDefault('$(DepAspNetCoreCommit)', '$(BUILD_SOURCEVERSION)'))" />
45+
<Line Include="windowsdesktop" Version="$(MicrosoftWindowsDesktopAppRefPackageVersion)" Commit="$([MSBuild]::ValueOrDefault('$(DepWindowsDesktopCommit)', '$(BUILD_SOURCEVERSION)'))" />
4246
<Line Include="sdk" Version="$(PackageVersion)" Commit="$(BUILD_SOURCEVERSION)" />
4347
</ItemGroup>
4448

@@ -71,7 +75,6 @@
7175
Lines="$(JsonContents)"
7276
Overwrite="true"
7377
Encoding="ASCII" />
74-
7578
</Target>
7679

7780
<Target Name="GenerateBundledVersionsProps">

src/Layout/redist/targets/OverlaySdkOnLKG.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
<PropertyGroup>
44
<TestHostFolder>$(ArtifactsBinDir)redist\$(Configuration)\dotnet\</TestHostFolder>
5-
<TestHostDotNet>$(TestHostFolder)$([System.IO.Path]::GetFileName('$(DotNetTool)'))</TestHostDotNet>
65
</PropertyGroup>
76

87
<Target Name="OverlaySdkOnLKG" AfterTargets="Build" DependsOnTargets="GenerateInstallerLayout">

0 commit comments

Comments
 (0)