Skip to content

Commit 5a85183

Browse files
nagilsongithub-actions
authored andcommitted
Disable flakey container registry tests
These tests have a high number of failures documented at (Skip = "#49502"). The registry issue may not be solved until funding is increased or engineering effort is made to handle this case better and not run the tests. Merge
1 parent 8242b27 commit 5a85183

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

test/Microsoft.NET.Build.Containers.IntegrationTests/DockerRegistryTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public DockerRegistryTests(ITestOutputHelper testOutput)
1717
_loggerFactory = new TestLoggerFactory(testOutput);
1818
}
1919

20-
[DockerAvailableFact]
20+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
2121
public async Task GetFromRegistry()
2222
{
2323
var loggerFactory = new TestLoggerFactory(_testOutput);

test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void Dispose()
4242
_loggerFactory.Dispose();
4343
}
4444

45-
[DockerAvailableFact()]
45+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
4646
public async Task ApiEndToEndWithRegistryPushAndPull()
4747
{
4848
ILogger logger = _loggerFactory.CreateLogger(nameof(ApiEndToEndWithRegistryPushAndPull));
@@ -89,7 +89,7 @@ public async Task ApiEndToEndWithRegistryPushAndPull()
8989
}
9090
}
9191

92-
[DockerAvailableFact()]
92+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
9393
public async Task ApiEndToEndWithLocalLoad()
9494
{
9595
ILogger logger = _loggerFactory.CreateLogger(nameof(ApiEndToEndWithLocalLoad));
@@ -130,7 +130,7 @@ public async Task ApiEndToEndWithLocalLoad()
130130
}
131131
}
132132

133-
[DockerAvailableFact()]
133+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
134134
public async Task ApiEndToEndWithArchiveWritingAndLoad()
135135
{
136136
ILogger logger = _loggerFactory.CreateLogger(nameof(ApiEndToEndWithArchiveWritingAndLoad));
@@ -180,7 +180,7 @@ public async Task ApiEndToEndWithArchiveWritingAndLoad()
180180
}
181181
}
182182

183-
[DockerAvailableFact]
183+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
184184
public async Task TarballsHaveCorrectStructure()
185185
{
186186
var archiveFile = Path.Combine(TestSettings.TestArtifactsDirectory,
@@ -351,7 +351,7 @@ private string BuildLocalApp([CallerMemberName] string testName = "TestName", st
351351
return publishDirectory;
352352
}
353353

354-
[DockerAvailableFact()]
354+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
355355
public async Task EndToEnd_MultiProjectSolution()
356356
{
357357
ILogger logger = _loggerFactory.CreateLogger(nameof(EndToEnd_MultiProjectSolution));
@@ -437,7 +437,7 @@ public async Task EndToEnd_MultiProjectSolution()
437437
/// It's safe to load the target for libraries in a multi-targeted context because libraries don't have EnableSdkContainerSupport
438438
/// enabled by default, so the target will be skipped.
439439
/// </summary>
440-
[DockerAvailableFact]
440+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
441441
public async Task EndToEnd_MultiProjectSolution_with_multitargeted_library()
442442
{
443443
ILogger logger = _loggerFactory.CreateLogger(nameof(EndToEnd_MultiProjectSolution_with_multitargeted_library));
@@ -505,7 +505,7 @@ public async Task EndToEnd_MultiProjectSolution_with_multitargeted_library()
505505
commandResult.Should().HaveStdOutContaining("Pushed image 'webapp:latest'");
506506
}
507507

508-
[DockerAvailableTheory()]
508+
[DockerAvailableTheory(Skip = "https://github.com/dotnet/sdk/issues/49502")]
509509
[InlineData("webapi", false)]
510510
[InlineData("webapi", true)]
511511
[InlineData("worker", false)]
@@ -682,7 +682,7 @@ public async Task EndToEnd_NoAPI_ProjectType(string projectType, bool addPackage
682682
privateNuGetAssets.Delete(true);
683683
}
684684

685-
[DockerAvailableTheory()]
685+
[DockerAvailableTheory(Skip = "https://github.com/dotnet/sdk/issues/49502")]
686686
[InlineData(DockerRegistryManager.FullyQualifiedBaseImageAspNet)]
687687
[InlineData(DockerRegistryManager.FullyQualifiedBaseImageAspNetDigest)]
688688
public void EndToEnd_NoAPI_Console(string baseImage)
@@ -764,7 +764,7 @@ public void EndToEnd_NoAPI_Console(string baseImage)
764764
privateNuGetAssets.Delete(true);
765765
}
766766

767-
[DockerAvailableFact]
767+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
768768
public void EndToEnd_SingleArch_NoRid()
769769
{
770770
// Create a new console project
@@ -854,7 +854,7 @@ public void EndToEndMultiArch_LocalRegistry(string imageName)
854854
newProjectDir.Delete(true);
855855
}
856856

857-
[DockerAvailableFact]
857+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
858858
public void MultiArchStillAllowsSingleRID()
859859
{
860860
string imageName = NewImageName();
@@ -905,7 +905,7 @@ public void MultiArchStillAllowsSingleRID()
905905
newProjectDir.Delete(true);
906906
}
907907

908-
[DockerAvailableFact]
908+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
909909
public void MultiArchStillAllowsSingleRIDUsingJustRIDProperties()
910910
{
911911
string imageName = NewImageName();
@@ -1418,7 +1418,7 @@ static string[] DecideEntrypoint(string rid, string appName, string workingDir)
14181418
}
14191419
}
14201420

1421-
[DockerAvailableFact]
1421+
[DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")]
14221422
public async void CheckDownloadErrorMessageWhenSourceRepositoryThrows()
14231423
{
14241424
var loggerFactory = new TestLoggerFactory(_testOutput);

0 commit comments

Comments
 (0)