Default sign to false for all SB legs (#44489)

Author: ellahathaway

eng/pipelines/templates/jobs/vmr-build.yml

@@ -282,7 +282,7 @@ jobs:
 
     - script: |
         set extraBuildArguments=
-        if /I '${{ parameters.sign }}'=='True' IF /I NOT '${{ parameters.buildSourceOnly }}' == 'True' set extraBuildArguments=%extraBuildArguments% -sign
+        if /I '${{ parameters.sign }}'=='True' (if /I NOT '${{ parameters.buildSourceOnly }}'=='True' (set extraBuildArguments=%extraBuildArguments% -sign))
         if /I '${{ parameters.useDevVersions }}'=='True' set extraBuildArguments=%extraBuildArguments% -dev
         set extraBuildProperties=
         if not [${{ parameters.buildPass }}]==[] set extraBuildProperties=%extraBuildProperties% /p:DotNetBuildPass=${{ parameters.buildPass }}
@@ -367,7 +367,7 @@ jobs:
           customBuildArgs="$customBuildArgs --dev"
         fi
 
-        if [[ '${{ parameters.sign }}' == 'True' && '${{ parameters.buildSourceOnly }}' != 'True' ]]; then
+        if [[ '${{ parameters.sign }}' == 'True' ]] && [[ '${{ parameters.buildSourceOnly }}' != 'True' ]]; then
           customBuildArgs="$customBuildArgs --sign"
         fi
 

eng/pipelines/templates/stages/vmr-build.yml

@@ -100,7 +100,6 @@ stages:
         runOnline: true                    # ✅
         useMonoRuntime: false              # 🚫
         withPreviousSDK: false             # 🚫
-        sign: false
 
     ### Additional jobs for lite/full builds ###
     - ${{ if in(parameters.scope, 'lite', 'full') }}:
@@ -124,7 +123,6 @@ stages:
       #     withPreviousSDK: false             # 🚫
       #     reuseBuildArtifactsFrom:
       #     - ${{ format('{0}_Online_MsftSdk_x64', variables.centOSStreamName) }}
-      #     sign: false
 
       # Disabled until net9.0 -> net10.0 transition is complete - see https://github.com/dotnet/source-build/issues/4605
       # - template: ../jobs/vmr-build.yml
@@ -145,7 +143,6 @@ stages:
       #     runOnline: false                   # 🚫
       #     useMonoRuntime: false              # 🚫
       #     withPreviousSDK: true              # ✅
-      #     sign: false
 
       - template: ../jobs/vmr-build.yml
         parameters:
@@ -163,7 +160,6 @@ stages:
           runOnline: false                   # 🚫
           useMonoRuntime: false              # 🚫
           withPreviousSDK: false             # 🚫
-          sign: false
 
       ### Additional jobs for full build ###
       - ${{ if in(parameters.scope, 'full') }}:
@@ -186,7 +182,6 @@ stages:
             runOnline: false                   # 🚫
             useMonoRuntime: false              # 🚫
             withPreviousSDK: false             # 🚫
-            sign: false
 
         - template: ../jobs/vmr-build.yml
           parameters:
@@ -205,7 +200,6 @@ stages:
             runOnline: true                    # ✅
             useMonoRuntime: false              # 🚫
             withPreviousSDK: false             # 🚫
-            sign: false
 
         - template: ../jobs/vmr-build.yml
           parameters:
@@ -223,7 +217,6 @@ stages:
             runOnline: false                   # 🚫
             useMonoRuntime: false              # 🚫
             withPreviousSDK: false             # 🚫
-            sign: false
 
         # Disabled until net9.0 -> net10.0 transition is complete - see https://github.com/dotnet/source-build/issues/4605
         # - template: ../jobs/vmr-build.yml
@@ -243,7 +236,6 @@ stages:
         #     runOnline: true                    # ✅
         #     useMonoRuntime: false              # 🚫
         #     withPreviousSDK: true              # ✅
-        #     sign: false
 
         # Disabled until net9.0 -> net10.0 transition is complete - see https://github.com/dotnet/source-build/issues/4605
         # - template: ../jobs/vmr-build.yml
@@ -263,7 +255,6 @@ stages:
         #     runOnline: false                   # 🚫
         #     useMonoRuntime: false              # 🚫
         #     withPreviousSDK: true              # ✅
-        #     sign: false
 
         - template: ../jobs/vmr-build.yml
           parameters:
@@ -281,7 +272,6 @@ stages:
             runOnline: false                   # 🚫
             useMonoRuntime: true               # ✅
             withPreviousSDK: false             # 🚫
-            sign: false
 
         - template: ../jobs/vmr-build.yml
           parameters:
@@ -299,8 +289,6 @@ stages:
             runOnline: false                   # 🚫
             useMonoRuntime: false              # 🚫
             withPreviousSDK: false             # 🚫
-            sign: false
-
 
         - template: ../jobs/vmr-build.yml
           parameters:
@@ -318,7 +306,6 @@ stages:
             runOnline: false                   # 🚫
             useMonoRuntime: false              # 🚫
             withPreviousSDK: false             # 🚫
-            sign: false
 
         # Disabled until net9.0 -> net10.0 transition is complete - see https://github.com/dotnet/source-build/issues/4605
         # - template: ../jobs/vmr-build.yml
@@ -339,7 +326,6 @@ stages:
         #     withPreviousSDK: false             # 🚫
         #     reuseBuildArtifactsFrom:
         #     - ${{ format('{0}_Offline_MsftSdk_x64', variables.fedoraName) }}
-        #     sign: false
 
         # Disabled until net9.0 -> net10.0 transition is complete - see https://github.com/dotnet/source-build/issues/4605
         # - template: ../jobs/vmr-build.yml
@@ -360,7 +346,6 @@ stages:
         #     withPreviousSDK: false             # 🚫
         #     reuseBuildArtifactsFrom:
         #     - ${{ format('{0}_Mono_Offline_MsftSdk_x64', variables.centOSStreamName) }}
-        #     sign: false
 
 #### VERTICAL BUILD ####
 - ${{ if not(parameters.isSourceOnlyBuild) }}: