Use DotnetBuildCommand instead of BuildCommand for It_does_not_download_desktop_targeting_packs_on_unix. Change test folder name hashing for TestAssetsManager as the previous one didn't hash it well enough including the identifier (even with different identifiers, the values were the same).

Author: MiYanni

test/EndToEnd.Tests/GivenWeWantToRequireWindowsForDesktopApps.cs

@@ -20,7 +20,7 @@ public void It_does_not_download_desktop_targeting_packs_on_unix()
 
             var testInstance = testProjectCreator.Create(_testAssetsManager);
 
-            new BuildCommand(testInstance)
+            new DotnetBuildCommand(testInstance)
                 .Execute().Should().Pass();
 
             string packagesPath = Path.Combine(testInstance.TestRoot, "packages");

test/EndToEnd.Tests/ProjectBuildTests.cs

@@ -459,10 +459,8 @@ private void TestTemplateCreateAndBuild(string templateName, bool build = true,
 
         private TestDirectory InstantiateProjectTemplate(string templateName, string language = "", bool withNoRestore = true)
         {
-            var directory = _testAssetsManager.CreateTestDirectory(
-                identifier: string.IsNullOrWhiteSpace(language)
-                ? templateName
-                : $"{templateName}[{language}]");
+            var identifier = string.IsNullOrWhiteSpace(language) ? templateName : $"{templateName}[{language}]";
+            var directory = _testAssetsManager.CreateTestDirectory(identifier: identifier);
             string projectDirectory = directory.Path;
 
             string[] newArgs = [

test/Microsoft.NET.TestFramework/TestAssetsManager.cs

@@ -187,18 +187,15 @@ public static string GetTestDestinationDirectoryPath(
             // We need to ensure the directory name isn't over 24 characters in length
             if (directoryName.Length > 24)
             {
-                using (var sha256 = SHA256.Create())
-                {
-                    var hash = sha256.ComputeHash(Encoding.UTF8.GetBytes(directoryName.ToString()));
+                var hash = GetTruncatedHash(directoryName.ToString(), HashAlgorithmName.SHA256);
 
-                    directoryName = directoryName.Remove(13, directoryName.Length - 13)
-                                                 .Append("---");
+                directoryName = directoryName.Remove(13, directoryName.Length - 13)
+                                             .Append("---");
 
-                    directoryName = directoryName.AppendFormat("{0:X2}", hash[0])
-                                                 .AppendFormat("{0:X2}", hash[1])
-                                                 .AppendFormat("{0:X2}", hash[2])
-                                                 .AppendFormat("{0:X2}", hash[3]);
-                }
+                directoryName = directoryName.AppendFormat("{0:X2}", hash[0])
+                                             .AppendFormat("{0:X2}", hash[1])
+                                             .AppendFormat("{0:X2}", hash[2])
+                                             .AppendFormat("{0:X2}", hash[3]);
             }
 
             var directoryPath = Path.Combine(baseDirectory, directoryName.ToString());
@@ -215,6 +212,25 @@ public static string GetTestDestinationDirectoryPath(
 #endif
 
             return directoryPath;
+
+            // From: https://github.com/dotnet/arcade/blob/3b7e3a1a6d626eb51c5528987c1af484a98e4b5c/src/Microsoft.DotNet.Build.Tasks.Workloads/src/Utils.cs#L22
+            static string GetTruncatedHash(string value, HashAlgorithmName hashName)
+            {
+                byte[] bytes = Encoding.UTF8.GetBytes(value);
+#pragma warning disable SYSLIB0045 // Cryptographic factory methods accepting an algorithm name are obsolete. Use the parameterless Create factory method on the algorithm type instead.
+                HashAlgorithm algorithm = HashAlgorithm.Create(hashName.Name);
+#pragma warning restore SYSLIB0045
+                StringBuilder sb = new();
+
+                foreach (byte b in algorithm.ComputeHash(bytes))
+                {
+                    sb.Append(b.ToString("x2"));
+                }
+
+                string result = sb.ToString();
+
+                return result.Substring(0, 32);
+            }
         }
     }
 }