Allow charset to be unset (#42266)

JoeRobich · web-flow · commit 6175995c5227 · 2025-09-25T14:44:33.000-07:00
diff --git a/src/BuiltInTools/dotnet-format/Formatters/CharsetFormatter.cs b/src/BuiltInTools/dotnet-format/Formatters/CharsetFormatter.cs
@@ -68,7 +68,8 @@ private static byte[] GetEncodedBytes(string text, Encoding encoding)
         private static bool TryGetCharset(AnalyzerConfigOptions analyzerConfigOptions, [NotNullWhen(true)] out Encoding? encoding)
         {
             if (analyzerConfigOptions != null &&
-                analyzerConfigOptions.TryGetValue("charset", out var charsetOption))
+                analyzerConfigOptions.TryGetValue("charset", out var charsetOption) &&
+                charsetOption != "unset")
             {
                 encoding = GetCharset(charsetOption);
                 return true;

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,8 @@ private static byte[] GetEncodedBytes(string text, Encoding encoding)`
`68`	`68`	`private static bool TryGetCharset(AnalyzerConfigOptions analyzerConfigOptions, [NotNullWhen(true)] out Encoding? encoding)`
`69`	`69`	`{`
`70`	`70`	`if (analyzerConfigOptions != null &&`
`71`		`- analyzerConfigOptions.TryGetValue("charset", out var charsetOption))`
	`71`	`+ analyzerConfigOptions.TryGetValue("charset", out var charsetOption) &&`
	`72`	`+ charsetOption != "unset")`
`72`	`73`	`{`
`73`	`74`	`encoding = GetCharset(charsetOption);`
`74`	`75`	`return true;`