Skip to content

Commit 62c9743

Browse files
committed
Apply code review feedback and fix test
1 parent 904eb64 commit 62c9743

15 files changed

+43
-43
lines changed

src/Cli/dotnet/commands/dotnet-workload/install/LocalizableStrings.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@
327327
</data>
328328
<data name="CannotUseSkipManifestWithGlobalJsonWorkloadVersion" xml:space="preserve">
329329
<value>Cannot use the {0} option when workload version is specified in global.json. Remove the {0} option, or remove the 'workloadVersion' element from {1}.</value>
330-
<comment>"workloadVersion" is a literal value and should not be translated.</comment>
330+
<comment>"workloadVersion" and "global.json" are literal values and should not be translated.</comment>
331331
</data>
332332
<data name="SkipSignCheckOptionDescription" xml:space="preserve">
333333
<value>Skip signature verification of workload packages and installers.</value>
@@ -360,6 +360,6 @@
360360
<value>Successfully updated workload install mode to use {0}.</value>
361361
</data>
362362
<data name="FailedToInstallWorkloadSet" xml:space="preserve">
363-
<value>Failed to install workload set version {0}: {1}</value>
363+
<value>Failed to install workload version {0}: {1}</value>
364364
</data>
365365
</root>

src/Cli/dotnet/commands/dotnet-workload/install/xlf/LocalizableStrings.cs.xlf

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/commands/dotnet-workload/install/xlf/LocalizableStrings.de.xlf

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/commands/dotnet-workload/install/xlf/LocalizableStrings.es.xlf

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/commands/dotnet-workload/install/xlf/LocalizableStrings.fr.xlf

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/commands/dotnet-workload/install/xlf/LocalizableStrings.it.xlf

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/commands/dotnet-workload/install/xlf/LocalizableStrings.ja.xlf

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/commands/dotnet-workload/install/xlf/LocalizableStrings.ko.xlf

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/commands/dotnet-workload/install/xlf/LocalizableStrings.pl.xlf

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Cli/dotnet/commands/dotnet-workload/install/xlf/LocalizableStrings.pt-BR.xlf

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)