Set the default value of Create Manifest If Needed to True

nagilson · nagilson · commit 6ac69811e203 · 2025-05-12T10:29:33.000-07:00
This should enable the findFirst function to create a tool manifest by default. Will break some tests. On initial glance,, the arg behavior only seems to be inherited  by tool install local, which is all I want to impact right now. Although it also gets inherited by the construct command in command parser.
diff --git a/src/Cli/dotnet/Commands/Tool/Install/ToolInstallCommandParser.cs b/src/Cli/dotnet/Commands/Tool/Install/ToolInstallCommandParser.cs
@@ -51,7 +51,8 @@ internal static class ToolInstallCommandParser
     public static readonly Option<bool> CreateManifestIfNeededOption = new("--create-manifest-if-needed")
     {
         Description = CliCommandStrings.CreateManifestIfNeededOptionDescription,
-        Arity = ArgumentArity.Zero
+        Arity = ArgumentArity.Zero,
+        DefaultValueFactory = _ => true,
     };
 
     public static readonly Option<bool> AllowPackageDowngradeOption = new("--allow-downgrade")

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,8 @@ internal static class ToolInstallCommandParser`
`51`	`51`	`public static readonly Option<bool> CreateManifestIfNeededOption = new("--create-manifest-if-needed")`
`52`	`52`	`{`
`53`	`53`	`Description = CliCommandStrings.CreateManifestIfNeededOptionDescription,`
`54`		`- Arity = ArgumentArity.Zero`
	`54`	`+ Arity = ArgumentArity.Zero,`
	`55`	`+ DefaultValueFactory = _ => true,`
`55`	`56`	`};`
`56`	`57`
`57`	`58`	`public static readonly Option<bool> AllowPackageDowngradeOption = new("--allow-downgrade")`