[FIX] tool-update: Compare tool versions correctly

edvilme · edvilme · commit 7032fbbb43c2 · 2025-01-06T13:13:32.000-06:00
diff --git a/src/Cli/dotnet/commands/dotnet-tool/install/ToolInstallGlobalOrToolPathCommand.cs b/src/Cli/dotnet/commands/dotnet-tool/install/ToolInstallGlobalOrToolPathCommand.cs
@@ -249,7 +249,7 @@ private NuGetVersion GetBestMatchNugetVersion(PackageId packageId, VersionRange
 
         private static bool ToolVersionAlreadyInstalled(IToolPackage oldPackageNullable, NuGetVersion nuGetVersion)
         {
-            return oldPackageNullable != null && (oldPackageNullable.Version.Version == nuGetVersion.Version);
+            return oldPackageNullable != null && (oldPackageNullable.Version == nuGetVersion);
         }
 
         private static void EnsureVersionIsHigher(IToolPackage oldPackageNullable, IToolPackage newInstalledPackage, bool allowDowngrade)

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ private NuGetVersion GetBestMatchNugetVersion(PackageId packageId, VersionRange`
`249`	`249`
`250`	`250`	`private static bool ToolVersionAlreadyInstalled(IToolPackage oldPackageNullable, NuGetVersion nuGetVersion)`
`251`	`251`	`{`
`252`		`- return oldPackageNullable != null && (oldPackageNullable.Version.Version == nuGetVersion.Version);`
	`252`	`+ return oldPackageNullable != null && (oldPackageNullable.Version == nuGetVersion);`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`private static void EnsureVersionIsHigher(IToolPackage oldPackageNullable, IToolPackage newInstalledPackage, bool allowDowngrade)`